[breaking] refactor: Datepicker simple/range/single #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
klaascuvelier
force-pushed
the
refactor-datepicker
branch
2 times, most recently
from
df1790e
to
b660886
Compare
klaascuvelier
force-pushed
the
refactor-datepicker
branch
from
b660886
to
07d0a5f
Compare
|
@Akshat55 is this something we can bring to cca-6? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2822
This MR refactors the way the
datapickeranddatepicker-input componentwork. It de-deduplicates DOM elements & classes by introducing adatePickerTypeinput over therangeinput.This is a breaking change, however it aligns the component better with the React implementation.
Changelog
Changed
datepickeranddatepicker-inputrefactored