We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is an incorrect type definition for TranslationStrings
https://github.com/carbon-design-system/carbon-components-angular/blob/7967695ff011a0e42761f4fcf766820bdd2e1bef/src/i18n/i18n.service.ts#L138C1-L138C60
it should in fact support nested values like in the en.ts file
i suggest to modify it to
export type TranslationStrings = { [key: string]: string | { [key: string]: string | TranslationStrings }; };
Thanks
latest carbon-angular-components. version
The text was updated successfully, but these errors were encountered:
I think you are correct, but I think your suggestion can be simplified to
export type TranslationStrings = { [key: string]: string | TranslationStrings; };
I created a PR where I updated the type :)
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
This is an incorrect type definition for TranslationStrings
https://github.com/carbon-design-system/carbon-components-angular/blob/7967695ff011a0e42761f4fcf766820bdd2e1bef/src/i18n/i18n.service.ts#L138C1-L138C60
it should in fact support nested values like in the en.ts file
i suggest to modify it to
Thanks
latest carbon-angular-components. version
The text was updated successfully, but these errors were encountered: