Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination icon doesn't show when pages > 1000 #3075

Open
launderex619 opened this issue Nov 27, 2024 · 1 comment · May be fixed by #3076
Open

Pagination icon doesn't show when pages > 1000 #3075

launderex619 opened this issue Nov 27, 2024 · 1 comment · May be fixed by #3076

Comments

@launderex619
Copy link

Hello team, there is a hardcoded number in pagination.component.ts in line 140

Image

that makes pagination inconsistent when large amount of data:

Working example:
Image

When large amount of data:
Image

I think the solution might be remove that hardcoded 1000 and use the pageSelectThreshold variable

@launderex619 launderex619 changed the title Pagination icon doesn't show when pages >= 1000 Pagination icon doesn't show when pages > 1000 Nov 27, 2024
@klaascuvelier
Copy link
Contributor

Seems like a mistake indeed. I created a PR to fix this and added some unit tests for the switch between select/input too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants