Fix: allow tooltip disabled icon button #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Akshat55
requested changes
Nov 20, 2024
klaascuvelier
force-pushed
the
fix-3049-tooltip-disabled-icon-button
branch
from
0ee822c
to
366c79c
Compare
klaascuvelier
force-pushed
the
fix-3049-tooltip-disabled-icon-button
branch
from
366c79c
to
06df8ea
Compare
|
Both remarks have been addressed @Akshat55, not sure if you want me to resolve them or you rather do it yourself after checking it out. |
Akshat55
approved these changes
Nov 22, 2024
|
🎉 This PR is included in version 5.56.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.0.0-rc.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3049
Fix regression from v4: this will not hide the tooltip for a disabled icon-button.
Changelog
Changed