fix: handle null in writeValue when in multiselect mode and itemValueKey is defined #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…alueKey is defined
koenvd
force-pushed
the
combobox_value_safety_in_multi_select
branch
from
01b8517
to
1a4b698
Compare
Akshat55
approved these changes
Nov 25, 2024
Akshat55
changed the title
|
🎉 This PR is included in version 5.56.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2931
Noticed when in multiselect mode and when defining itemValueKey writeValue cannot properly handle null.
Added fallback for
null, added test to make sure as well the model is updated byitemValueKeywhen defined and not with the complete objects.