fix(side-panel): import missing icon-button and codesandbox example #11821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annawen1
requested review from
IgnacioBecerra and
sangeethababu9223
and removed request for
a team
|
Deploy preview created for package Built with commit: 2dcffac3a3d739b311d5e2fad21f81d7bcc53c46 |
|
Deploy preview created for package Built with commit: 2dcffac3a3d739b311d5e2fad21f81d7bcc53c46 |
|
Deploy preview created for package Built with commit: 2dcffac3a3d739b311d5e2fad21f81d7bcc53c46 |
ariellalgilmore
approved these changes
May 24, 2024
|
Deploy preview created for package Built with commit: 2dcffac3a3d739b311d5e2fad21f81d7bcc53c46 |
annawen1
changed the title
annawen1
added
the
Ready to merge
kodiakhq
bot
merged commit 3c51597
into
carbon-design-system:main
13 of 20 checks passed
Valentin-Sorin-Nicolae
pushed a commit
to Valentin-Sorin-Nicolae/carbon-for-ibm-dotcom
that referenced
this pull request
Jun 4, 2024
…arbon-design-system#11821) ### Related Ticket(s) Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}} ### Description Adds missing icon-button import to side-panel Also improves the codesandbox example ### Changelog **Changed** - working codesandbox example - added icon-button import to side-panel <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
jkaeser
added a commit
that referenced
this pull request
Jun 6, 2024
* feat(leaving-ibm): add shadow parts * Update packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/leaving-ibm/leaving-ibm-modal-body.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/leaving-ibm/leaving-ibm-modal-body.ts Co-authored-by: John Kaeser <[email protected]> * feat(global-banner): add shadow parts (#11840) * feat(global-banner): add shadow parts * Update packages/web-components/src/components/global-banner/global-banner.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/global-banner/global-banner.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/global-banner/global-banner.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/global-banner/global-banner.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/global-banner/global-banner.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/global-banner/global-banner.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/global-banner/global-banner.ts Co-authored-by: John Kaeser <[email protected]> --------- Co-authored-by: John Kaeser <[email protected]> * chore(dco): add ibm-mend-app to allowlist * chore(dco): add ibm-mend-app to allowlist * Add .whitesource configuration file (#11820) Co-authored-by: ibm-mend-app[bot] <142626574+ibm-mend-app[bot]@users.noreply.github.com> Co-authored-by: Jeff Chew <[email protected]> * fix(side-panel): import missing icon-button and codesandbox example (#11821) ### Related Ticket(s) Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}} ### Description Adds missing icon-button import to side-panel Also improves the codesandbox example ### Changelog **Changed** - working codesandbox example - added icon-button import to side-panel <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> * chore(settings): update settings to v2.10.0 * chore(release): publish - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] * chore(sticky-header): port refactor to v2 (#11773) ### Description Ports changes made to feat/masthead-v2-dev branch in #11734 to v2 branch. In order to adequately test the new Sticky Header Sandbox story, I had to clean up the Dotcom Shell stories. The `mock` secret menu item works again now, and I've reduced a good amount of bloat in the stories' markup. While I was at it, I noticed I never updated Dotcom Shell's `navLinks` prop for L0 items to Masthead's new `l0Data` prop, so I added support for that as well. ### Testing The code changes here are mostly identical to the aforementioned PR, with the only divergences being changes necessary for v2. Please verify each of the Dotcom Shell stories works as expected, taking particular care to test the sticky elements behaviors on both desktop and mobile. * feat(leaving-ibm): add shadow parts * feat(global-banner): run yarn format --------- Co-authored-by: John Kaeser <[email protected]> Co-authored-by: Jeff Chew <[email protected]> Co-authored-by: ibm-mend-app[bot] <142626574+ibm-mend-app[bot]@users.noreply.github.com> Co-authored-by: Anna Wen <[email protected]> Co-authored-by: ibmdotcom-bot <[email protected]>
|
Hey there! This issue/pull request was referenced in recently released v2.10.0. |
annawen1
added a commit
to annawen1/carbon-for-ibm-dotcom
that referenced
this pull request
Jul 24, 2024
…arbon-design-system#11821) ### Related Ticket(s) Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}} ### Description Adds missing icon-button import to side-panel Also improves the codesandbox example ### Changelog **Changed** - working codesandbox example - added icon-button import to side-panel <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}}
Description
Adds missing icon-button import to side-panel
Also improves the codesandbox example
Changelog
Changed