-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(side-panel): import missing icon-button and codesandbox example #11821
fix(side-panel): import missing icon-button and codesandbox example #11821
Conversation
Deploy preview created for package Built with commit: 2dcffac3a3d739b311d5e2fad21f81d7bcc53c46 |
Deploy preview created for package Built with commit: 2dcffac3a3d739b311d5e2fad21f81d7bcc53c46 |
Deploy preview created for package Built with commit: 2dcffac3a3d739b311d5e2fad21f81d7bcc53c46 |
Deploy preview created for package Built with commit: 2dcffac3a3d739b311d5e2fad21f81d7bcc53c46 |
3c51597
into
carbon-design-system:main
…arbon-design-system#11821) ### Related Ticket(s) Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}} ### Description Adds missing icon-button import to side-panel Also improves the codesandbox example ### Changelog **Changed** - working codesandbox example - added icon-button import to side-panel <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
* feat(leaving-ibm): add shadow parts * Update packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/leaving-ibm/leaving-ibm-composite.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/leaving-ibm/leaving-ibm-modal-body.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/leaving-ibm/leaving-ibm-modal-body.ts Co-authored-by: John Kaeser <[email protected]> * feat(global-banner): add shadow parts (#11840) * feat(global-banner): add shadow parts * Update packages/web-components/src/components/global-banner/global-banner.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/global-banner/global-banner.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/global-banner/global-banner.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/global-banner/global-banner.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/global-banner/global-banner.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/global-banner/global-banner.ts Co-authored-by: John Kaeser <[email protected]> * Update packages/web-components/src/components/global-banner/global-banner.ts Co-authored-by: John Kaeser <[email protected]> --------- Co-authored-by: John Kaeser <[email protected]> * chore(dco): add ibm-mend-app to allowlist * chore(dco): add ibm-mend-app to allowlist * Add .whitesource configuration file (#11820) Co-authored-by: ibm-mend-app[bot] <142626574+ibm-mend-app[bot]@users.noreply.github.com> Co-authored-by: Jeff Chew <[email protected]> * fix(side-panel): import missing icon-button and codesandbox example (#11821) ### Related Ticket(s) Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}} ### Description Adds missing icon-button import to side-panel Also improves the codesandbox example ### Changelog **Changed** - working codesandbox example - added icon-button import to side-panel <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> * chore(settings): update settings to v2.10.0 * chore(release): publish - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] * chore(sticky-header): port refactor to v2 (#11773) ### Description Ports changes made to feat/masthead-v2-dev branch in #11734 to v2 branch. In order to adequately test the new Sticky Header Sandbox story, I had to clean up the Dotcom Shell stories. The `mock` secret menu item works again now, and I've reduced a good amount of bloat in the stories' markup. While I was at it, I noticed I never updated Dotcom Shell's `navLinks` prop for L0 items to Masthead's new `l0Data` prop, so I added support for that as well. ### Testing The code changes here are mostly identical to the aforementioned PR, with the only divergences being changes necessary for v2. Please verify each of the Dotcom Shell stories works as expected, taking particular care to test the sticky elements behaviors on both desktop and mobile. * feat(leaving-ibm): add shadow parts * feat(global-banner): run yarn format --------- Co-authored-by: John Kaeser <[email protected]> Co-authored-by: Jeff Chew <[email protected]> Co-authored-by: ibm-mend-app[bot] <142626574+ibm-mend-app[bot]@users.noreply.github.com> Co-authored-by: Anna Wen <[email protected]> Co-authored-by: ibmdotcom-bot <[email protected]>
Hey there! This issue/pull request was referenced in recently released v2.10.0. |
…arbon-design-system#11821) ### Related Ticket(s) Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}} ### Description Adds missing icon-button import to side-panel Also improves the codesandbox example ### Changelog **Changed** - working codesandbox example - added icon-button import to side-panel <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Related Ticket(s)
Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}}
Description
Adds missing icon-button import to side-panel
Also improves the codesandbox example
Changelog
Changed