Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons are missing from the Iconography page on Carbon Design System website #103

Open
Yohanna opened this issue May 14, 2019 · 7 comments

Comments

@Yohanna
Copy link

Yohanna commented May 14, 2019

Some icons are missing from the Carbon Design System website but their SVG is available in the repo and can be used.

For instance, I'm using 3 icons in here: https://codesandbox.io/s/6lp7w5p953 that can't be found when you search for them on the Iconography page.

@Yohanna Yohanna changed the title Some icons are missing from carbondesignsystem.com Some icons are missing from the Iconography page on Carbon Design System website May 14, 2019
@conradennis
Copy link

conradennis commented May 21, 2019

@Yohanna those icons are not compliant with the new IBM Design Language and therefore won't show up on the site or in the library. They may be in the repo because they're legacy icons that are still in use in certain products. You should reach out to Chris Connors about this.

If you do need newer versions for those icons pull what you can from the current library and/or submit a request here to have the missing ones created according to the new IDL standards.

@joshblack
Copy link
Contributor

Hi @Yohanna! 👋 These will most likely be moved over into specific Business Unit teams (like Cloud) instead of us managing them 👍

@Yohanna
Copy link
Author

Yohanna commented May 23, 2019

Hi @conradennis and @joshblack, thanks for looking into this.
Do you know if there are any issues in continuing to use the icons from carbon-icons v7? Do you plan on removing them from this repo any time soon?

@joshblack
Copy link
Contributor

@Yohanna I think we're going to keep them in this project as we moved to the new scoped package in a couple of weeks just to reduce any friction during the transition 👍 Afterwards, I think we'll end up just freezing this project so folks can still keep using it as-needed.

@shixiedesign
Copy link

Hi @Yohanna I'd encourage you to migrate to the new icons nevertheless (or create restyled version of these ones) . Josh is probably right that we won't "delete" the old icons right now, but at some point, they might be removed to better ensure all IBM products move towards the new language. This is only my guess. This decision is not made yet.

@joshblack
Copy link
Contributor

@shixiedesign if it helps, the icons in question are service provider icons and not necessarily icons used in components. Since they are service provider icons, these will be coming from IBM Cloud which hasn't switched to v10 yet. I'll try and double-check with their team if they're are considering these icons when it comes to updates 👍

@shixiedesign
Copy link

Oops I see. Thanks for the correction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants