Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution: Legend #113

Open
voranouth-s opened this issue Oct 21, 2019 · 4 comments
Open

Contribution: Legend #113

voranouth-s opened this issue Oct 21, 2019 · 4 comments

Comments

@voranouth-s
Copy link

1. Team name

IBM Watson Studio

2. Icon name

Legend

3. Please briefly describe what the icon is supposed to represent and the use case(s) its being used for.

The legend icon is intended for a visualization's legend; A visualization legend is used to identify data by color, icon, shape, size and other key features.

In Watson Studio's case, we have a legend within a panel and need to have an icon to represent the visualization's legend. A user is able to click the icon to open, enable, or close the panel.

4. Box Link

https://ibm.box.com/s/l0h6mvt5i0gm8jhcnglz8nftbbb7gaba
Please let me know if this link does not work.

5. Screen Shot

With pixel grid:
Screen Shot 2019-10-20 at 9 55 50 PM
I am having a couple of issues with the 16 px icon design. The left 16 px icon is the minimized version of the 32 px icon (far right icon), but the middle item (square and line) falls on a half pixel. The middle 16 px icon is pixel perfect, but does not fall vertically centered within 16 px. The question I have is which 16 px icon design is correct / should I go with? Thanks in advance!

Without pixel grid:
Screen Shot 2019-10-20 at 9 56 04 PM

In context:
Screen Shot 2019-10-20 at 10 16 20 PM

@conradennis
Copy link

@voranouth-s thanks for the submission. we typically create our icons only at size 32px and then scale them to the other sizes so I don't think a bespoke 16px icon with slightly different placement is the solution.

Either we accept the middle line sitting on a half pixel which happens in many of the icons in the library or you could explore an option like the set below, maybe with strokes for the shapes instead of solids. Fell free to slack me @ ctennis to have a quicker back and forth

Screen Shot 2019-10-21 at 11 30 43 AM

@voranouth-s
Copy link
Author

Hi @conradennis,
Thank you for the suggestion of the list (2 lines vs 3); it worked out better for us.

Screen Shot 2019-10-23 at 9 49 41 AM

If needed, you can re-access that icon using the same box link above.

@conradennis
Copy link

conradennis commented Nov 12, 2019

@voranouth-s Great, i'm adding the icon to the repo/master soon. I made a tweak and changed the circle to a square to differentiate the icon a bit more from the "list--bulleted" icon. I can send over the official SVG today if you slack me directly.

Screen Shot 2019-11-12 at 12 03 05 PM

@mjabbink
Copy link

@conradennis Can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants