New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interplay between options.upsert and config.supportsUpsert #298

Open

tfogo opened this issue Dec 4, 2017 · 1 comment

Assignees

Contributor

tfogo commented Dec 4, 2017 •

edited

Loading

If supportsUpsert is set to true and the query upsert=false is sent with a request, upsert is not turned off. See: https://github.com/carbon-io/carbond/blob/master/lib/mongodb/MongoDBCollection.js#L545-L547

I would expect setting upsert off on the request level to override the setting on the collection level.

The text was updated successfully, but these errors were encountered:

tfogo assigned gregbanks

Contributor Author

tfogo commented Jan 3, 2018

@gregbanks should the query be overriding the collection setting here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment