Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ch1-q1? #29

Open
abohannon opened this issue May 24, 2018 · 1 comment
Open

Update ch1-q1? #29

abohannon opened this issue May 24, 2018 · 1 comment

Comments

@abohannon
Copy link

Would it make sense to change the params for the solutions to take a string rather than an array? I was thrown off by the use of sort in the second solution until I realized the "str" variable was actually an array.

The problem in the book clearly requests an implementation of an algorithm that works on a string. I suppose this is something the candidate could/should check before hand so I can understand reasoning for leaving it in.

@dsomel21
Copy link

Hi @abohannon, sorry for replying so late, I just came across this repo!

Are you referring to this file ? (Note, this link is the isUnique.js file that was committed on Aug 5, 2019).

The latest version of this file looks like this

In both commits, the params appear to be Strings... is there something that I am missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants