You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all: Thanks, I'm using autotest-notifications for several months now and I don't want to miss it anymore.
One thing bugged me thought: You just consider the last line of the output returned by autotest. But if you had failures in different test suites, autotest will run each suite separately. Your implementation notifies just about the last suite. If other plugins like test_benchmark add more lines at the end of the test results, your notifier will report exceptions.
First of all: Thanks, I'm using autotest-notifications for several months now and I don't want to miss it anymore.
One thing bugged me thought: You just consider the last line of the output returned by autotest. But if you had failures in different test suites, autotest will run each suite separately. Your implementation notifies just about the last suite. If other plugins like test_benchmark add more lines at the end of the test results, your notifier will report exceptions.
The fix is easy: Consider all lines of the result. I did it the quick & dirty way (without tests and I dropped rspec support, because I don't use it), so you probably won't use my fix, but it works for me: http://github.com/iGEL/autotest-notification/commit/22e1f59d8f91c3c8367829099de351b0f4ee636a
Would like to see a better solution in the main branch, though.
The text was updated successfully, but these errors were encountered: