Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You should consider all lines of the result, not just the last one #3

Open
iGEL opened this issue Jul 31, 2010 · 0 comments
Open

You should consider all lines of the result, not just the last one #3

iGEL opened this issue Jul 31, 2010 · 0 comments

Comments

@iGEL
Copy link

iGEL commented Jul 31, 2010

First of all: Thanks, I'm using autotest-notifications for several months now and I don't want to miss it anymore.

One thing bugged me thought: You just consider the last line of the output returned by autotest. But if you had failures in different test suites, autotest will run each suite separately. Your implementation notifies just about the last suite. If other plugins like test_benchmark add more lines at the end of the test results, your notifier will report exceptions.

The fix is easy: Consider all lines of the result. I did it the quick & dirty way (without tests and I dropped rspec support, because I don't use it), so you probably won't use my fix, but it works for me: http://github.com/iGEL/autotest-notification/commit/22e1f59d8f91c3c8367829099de351b0f4ee636a

Would like to see a better solution in the main branch, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant