Code review (#12)

* X500 distinguished name formatting changes

* Minor changes to string quoting

* Formatting changes

* SHA1 usage changes

* Formatting changes

* Use the decimal data type instead of the double data type

Author: carlosga

src/facturae/DataType/DoubleFourDecimalType.cs

@@ -8,10 +8,10 @@
 namespace FacturaE.DataType;
 
 public struct DoubleFourDecimalType
-    : IComparable, IFormattable, IConvertible, IComparable<double>, IEquatable<double>, IXmlSerializable
+    : IComparable, IFormattable, IConvertible, IComparable<decimal>, IEquatable<decimal>, IXmlSerializable
 {
-    public static readonly DoubleFourDecimalType MaxValue = new(double.MaxValue);
-    public static readonly DoubleFourDecimalType MinValue = new(double.MinValue);
+    public static readonly DoubleFourDecimalType MaxValue = new(decimal.MaxValue);
+    public static readonly DoubleFourDecimalType MinValue = new(decimal.MinValue);
 
     public static bool GreaterThan(DoubleFourDecimalType left, DoubleFourDecimalType right)
     {
@@ -40,102 +40,55 @@ public static bool NotEquals(DoubleFourDecimalType left, DoubleFourDecimalType r
 
     public static DoubleFourDecimalType Parse(string value)
     {
-        return new DoubleFourDecimalType(double.Parse(value));
+        return new DoubleFourDecimalType(decimal.Parse(value));
     }
 
     public static bool operator ==(DoubleFourDecimalType left, DoubleFourDecimalType right)
     {
-        bool equals = false;
-
-        if (left.Value == right.Value)
-        {
-            equals = true;
-        }
-
-        return equals;
+        return left.Value == right.Value;
     }
 
     public static bool operator !=(DoubleFourDecimalType left, DoubleFourDecimalType right)
     {
-        bool notequals = false;
-
-        if (left.Value != right.Value)
-        {
-            notequals = true;
-        }
-
-        return notequals;
+        return left.Value != right.Value;
     }
 
     public static bool operator >(DoubleFourDecimalType left, DoubleFourDecimalType right)
     {
-        bool greater = false;
-
-        if (left.Value > right.Value)
-        {
-            greater = true;
-        }
-
-        return greater;
+        return left.Value > right.Value;
     }
 
     public static bool operator >=(DoubleFourDecimalType left, DoubleFourDecimalType right)
     {
-        bool greater = false;
-
-        if (left.Value >= right.Value)
-        {
-            greater = true;
-        }
-
-        return greater;
+        return left.Value >= right.Value;
     }
 
     public static bool operator <(DoubleFourDecimalType left, DoubleFourDecimalType right)
     {
-        bool less = false;
-
-        if (left.Value < right.Value)
-        {
-            less = true;
-        }
-
-        return less;
+        return left.Value < right.Value;
     }
 
     public static bool operator <=(DoubleFourDecimalType left, DoubleFourDecimalType right)
     {
-        bool less = false;
-
-        if (left.Value <= right.Value)
-        {
-            less = true;
-        }
-
-        return less;
+        return left.Value <= right.Value;
     }
 
-    public static implicit operator double(DoubleFourDecimalType x)
+    public static implicit operator decimal(DoubleFourDecimalType x)
     {
         return x.Value;
     }
 
-    public static implicit operator DoubleFourDecimalType(double x)
+    public static implicit operator DoubleFourDecimalType(decimal x)
     {
         return new DoubleFourDecimalType(x);
     }
 
     [XmlIgnore]
-    public double Value { get; private set; }
-
-    public DoubleFourDecimalType(double value)
-    {
-        Value = value;
-    }
+    public decimal Value { get; private set; }
 
     public DoubleFourDecimalType(decimal value)
     {
-        Value = (double)value;
+        Value = value;
     }
 
     public override readonly int GetHashCode()
@@ -195,12 +148,12 @@ readonly DateTime IConvertible.ToDateTime(IFormatProvider provider)
 
     readonly decimal IConvertible.ToDecimal(IFormatProvider provider)
     {
-        return Convert.ToDecimal(Value);
+        return Value;
     }
 
     readonly double IConvertible.ToDouble(IFormatProvider provider)
     {
-        return Value;
+        return Convert.ToDouble(Value);
     }
 
     readonly short IConvertible.ToInt16(IFormatProvider provider)
@@ -253,12 +206,12 @@ readonly ulong IConvertible.ToUInt64(IFormatProvider provider)
         return Convert.ToUInt64(Value);
     }
 
-    readonly int IComparable<double>.CompareTo(double other)
+    readonly int IComparable<decimal>.CompareTo(decimal other)
     {
         return CompareTo(other);
     }
 
-    public readonly bool Equals(double other)
+    public readonly bool Equals(decimal other)
     {
         return Equals(other);
     }
@@ -272,7 +225,7 @@ public void ReadXml(XmlReader reader)
     {
         if (reader is not null)
         {
-            Value = reader.ReadElementContentAsDouble();
+            Value = reader.ReadElementContentAsDecimal();
         }
     }
 

src/facturae/DataType/DoubleSixDecimalType.cs

@@ -8,10 +8,10 @@
 namespace FacturaE.DataType;
 
 public struct DoubleSixDecimalType
-    : IComparable, IFormattable, IConvertible, IComparable<double>, IEquatable<double>, IXmlSerializable
+    : IComparable, IFormattable, IConvertible, IComparable<decimal>, IEquatable<decimal>, IXmlSerializable
 {
-    public static readonly DoubleSixDecimalType MaxValue = new(double.MaxValue);
-    public static readonly DoubleSixDecimalType	MinValue = new(double.MinValue);
+    public static readonly DoubleSixDecimalType MaxValue = new(decimal.MaxValue);
+    public static readonly DoubleSixDecimalType	MinValue = new(decimal.MinValue);
 
     public static bool GreaterThan(DoubleSixDecimalType left, DoubleSixDecimalType right)
     {
@@ -40,87 +40,45 @@ public static bool NotEquals(DoubleSixDecimalType left, DoubleSixDecimalType rig
 
     public static DoubleSixDecimalType Parse(string value)
     {
-        return new DoubleSixDecimalType(double.Parse(value));
+        return new DoubleSixDecimalType(decimal.Parse(value));
     }
 
     public static bool operator ==(DoubleSixDecimalType left, DoubleSixDecimalType right)
     {
-        bool equals = false;
-
-        if (left.Value == right.Value)
-        {
-            equals = true;
-        }
-
-        return equals;
+        return left.Value == right.Value;
     }
 
     public static bool operator !=(DoubleSixDecimalType left, DoubleSixDecimalType right)
     {
-        bool notequals = false;
-
-        if (left.Value != right.Value)
-        {
-            notequals = true;
-        }
-
-        return notequals;
+        return left.Value != right.Value;
     }
 
     public static bool operator >(DoubleSixDecimalType left, DoubleSixDecimalType right)
     {
-        bool greater = false;
-
-        if (left.Value > right.Value)
-        {
-            greater = true;
-        }
-
-        return greater;
+        return left.Value > right.Value;
     }
 
     public static bool operator >=(DoubleSixDecimalType left, DoubleSixDecimalType right)
     {
-        bool greater = false;
-
-        if (left.Value >= right.Value)
-        {
-            greater = true;
-        }
-
-        return greater;
+        return left.Value >= right.Value;
     }
 
     public static bool operator <(DoubleSixDecimalType left, DoubleSixDecimalType right)
     {
-        bool less = false;
-
-        if (left.Value < right.Value)
-        {
-            less = true;
-        }
-
-        return less;
+        return left.Value < right.Value;
     }
 
     public static bool operator <=(DoubleSixDecimalType left, DoubleSixDecimalType right)
     {
-        bool less = false;
-
-        if (left.Value <= right.Value)
-        {
-            less = true;
-        }
-
-        return less;
+        return left.Value <= right.Value;
     }
 
-    public static implicit operator double(DoubleSixDecimalType x)
+    public static implicit operator decimal(DoubleSixDecimalType x)
     {
         return x.Value;
     }
 
-    public static implicit operator DoubleSixDecimalType(double x)
+    public static implicit operator DoubleSixDecimalType(decimal x)
     {
         return new DoubleSixDecimalType(x);
     }
@@ -131,16 +89,11 @@ public static implicit operator DoubleSixDecimalType(DoubleTwoDecimalType x)
     }
 
     [XmlIgnore]
-    public double Value { get; private set; }
-
-    public DoubleSixDecimalType(double value)
-    {
-        Value = value;
-    }
+    public decimal Value { get; private set; }
 
     public DoubleSixDecimalType(decimal value)
     {
-        Value = (double)value;
+        Value = value;
     }
 
     public override readonly int GetHashCode()
@@ -200,12 +153,12 @@ readonly DateTime IConvertible.ToDateTime(IFormatProvider provider)
 
     readonly decimal IConvertible.ToDecimal(IFormatProvider provider)
     {
-        return Convert.ToDecimal(Value);
+        return Value;
     }
 
     readonly double IConvertible.ToDouble(IFormatProvider provider)
     {
-        return Value;
+        return Convert.ToDouble(Value);
     }
 
     readonly short IConvertible.ToInt16(IFormatProvider provider)
@@ -258,12 +211,12 @@ readonly ulong IConvertible.ToUInt64(IFormatProvider provider)
         return Convert.ToUInt64(Value);
     }
 
-    readonly int IComparable<double>.CompareTo(double other)
+    readonly int IComparable<decimal>.CompareTo(decimal other)
     {
         return CompareTo(other);
     }
 
-    public readonly bool Equals(double other)
+    public readonly bool Equals(decimal other)
     {
         return Equals(other);
     }
@@ -277,7 +230,7 @@ public void ReadXml(XmlReader reader)
     {
         if (reader is not null)
         {
-            Value = reader.ReadElementContentAsDouble();
+            Value = reader.ReadElementContentAsDecimal();
         }
     }