Added secondary application compiles, untested #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psmithcrl
requested review from
mattalvarado,
pdlr,
davidirobinson,
jatkinson-CRL and
bblakeslee-crl
Comment on lines
2991
to
2997
| DataSource source; | ||
| /** Bits per pixel in the secondaryAppData */ | ||
| uint32_t bitsPerPixel; | ||
| /** Width of the secondaryAppData */ | ||
| uint32_t width; | ||
| /** Height of the secondaryAppData*/ | ||
| uint32_t height; |
There was a problem hiding this comment.
Do these fields make sense? Is a void* with a length, associated frameID, and timestamp sufficient?
There was a problem hiding this comment.
No, I don't think hardly anything here makes sense yet.
I am kind of using this as a template and a test utility to evaluate running a secondary application on the camera.
I am going to change these fields, to make a basic demo.
There was a problem hiding this comment.
I think if we are going to support sending arbitrary number of bytes, we can let the user manually unpack it.
| /** The number of frames per second currently streaming from the device */ | ||
| float framesPerSecond; | ||
| /** The length of the secondaryAppData data stored in secondaryAppDataDataP */ | ||
| uint32_t secondaryAppDataLength; |
There was a problem hiding this comment.
Is this redundant with the length member?
…robotics/LibMultiSense into psmithcrl/example_secondary_app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some controls to help evaluate and test the functionality of the secondary application.
The primary goal being this will serve as an example for secondary application developers to use as a template for their application.