Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best DAG doesn't seem to be saved on it's own #29

Open
philtomson opened this issue Oct 4, 2018 · 0 comments
Open

Best DAG doesn't seem to be saved on it's own #29

philtomson opened this issue Oct 4, 2018 · 0 comments

Comments

@philtomson
Copy link

philtomson commented Oct 4, 2018

I notice that in Trainer.train() self.save_model() is called at certain times to save all of the shared weights in the "super graph" (my terminology), but I don't see that the best dag is tracked such that at the end of train() we have the best DAG/model RNN for the PTB task. save_model() saves all of the weights for the entire shared weight space, but doesn't show which DAG (which sub-graph of the larger graph) represents the best RNN constructed during training - unless I'm missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant