Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readBuffer & readSignalStrength #50

Open
pixelfriese opened this issue Jan 7, 2021 · 1 comment
Open

readBuffer & readSignalStrength #50

pixelfriese opened this issue Jan 7, 2021 · 1 comment

Comments

@pixelfriese
Copy link

Hi,

can someone verify the following two things:

In the readBuffer function, >= should be used instead of > in the following two places. Without this change I get an error message and the ESP32 reboots: "Stack smashing protect failure!"

if (i > count - 1)

if (i > count - 1)

Another thing is the readSignalStrength function. Returning AT+CSQ is much shorter. The length of the buffer should be 24 instead of 32. Without this change, the readBuffer function runs into timeout:

char buffer[32];

@carrascoacd
Copy link
Owner

Thanks for your issue @pixelfriese. Do you mind creating a PR with the changes that you suggest so I can check them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants