Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging when interacting with server-manager #541

Closed
7 tasks done
marcelstanley opened this issue Jul 30, 2024 · 1 comment
Closed
7 tasks done

Improve logging when interacting with server-manager #541

marcelstanley opened this issue Jul 30, 2024 · 1 comment
Assignees
Labels
#feat:inspect Feature: Inspect API #feat:machine-advancer Feature: machine advancer
Milestone

Comments

@marcelstanley
Copy link
Collaborator

marcelstanley commented Jul 30, 2024

📚 Context

Errors issued by the server-manager are currently being treated as warnings even in irrecoverable scenarios (re "session is tainted"). See sample node logs from debug session.

Such cases should be treated as errors and both the advance-runner and inspect-server should log them as such after such situations occur. These irrecoverable scenarios should be precisely logged that as well.

Additionally, the log levels used by both the advance-runner and inspect-server are not accurate and should be reviewed as well.

✔️ Solution

Update the advance-runner and inspect-server components to treat and log server-manager errors properly.

📈 Subtasks

  • advance-runner
    • update handling of server-manager errors
    • review all log levels
  • inspect-server
    • update handling of server-manager errors
    • review all log levels
  • Check for other necessary updates
@marcelstanley marcelstanley added #feat:inspect Feature: Inspect API #feat:machine-advancer Feature: machine advancer triage To be triaged 1.x labels Jul 30, 2024
@marcelstanley marcelstanley added this to the 1.5.1 milestone Jul 30, 2024
@marcelstanley marcelstanley removed the triage To be triaged label Jul 30, 2024
@marcelstanley marcelstanley changed the title Improve logging for server-manager errors Improve logging when interacting with server-manager Jul 30, 2024
@marcelstanley marcelstanley moved this to 📋 Backlog in Node Unit Jul 30, 2024
@marcelstanley marcelstanley removed the 1.x label Aug 2, 2024
@marcelstanley marcelstanley self-assigned this Aug 9, 2024
@marcelstanley marcelstanley moved this from 📋 Backlog to 🏗 In progress in Node Unit Aug 9, 2024
@marcelstanley marcelstanley removed their assignment Aug 9, 2024
@marcelstanley marcelstanley moved this from 🏗 In progress to 📋 Backlog in Node Unit Aug 9, 2024
@marcelstanley
Copy link
Collaborator Author

Amended description. Irrecoverable errors will be treated at #547

@marcelstanley marcelstanley moved this from 📋 Backlog to 🏗 In progress in Node Unit Aug 16, 2024
@marcelstanley marcelstanley self-assigned this Aug 16, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Node Unit Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#feat:inspect Feature: Inspect API #feat:machine-advancer Feature: machine advancer
Projects
Status: Done
Development

No branches or pull requests

1 participant