Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link in the debugging-crs page in kapp-controller docs #706

Closed
tiansiyuan opened this issue Dec 21, 2023 · 2 comments · Fixed by #708
Closed

Broken link in the debugging-crs page in kapp-controller docs #706

tiansiyuan opened this issue Dec 21, 2023 · 2 comments · Fixed by #708
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed documentation This issue indicates a change to the docs should be considered good first issue An issue that will be a good candidate for a new contributor

Comments

@tiansiyuan
Copy link

tiansiyuan commented Dec 21, 2023 •
edited by praveenrewar
Loading

The debugging-crs page has a broken link under the debugging PackageRepository cr heading.
The "More information here" should be pointing to status.usefulErrorMessage, and the correct way to do that would be to have something like

More information More information [here](#statususefulerrormessage)

Environment:

  • kapp Controller version (execute kubectl get deployment -n kapp-controller kapp-controller -o yaml and the annotation is kbld.k14s.io/images):
  • Kubernetes version (use kubectl version)

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.
@tiansiyuan tiansiyuan added bug This issue describes a defect or unexpected behavior carvel-triage labels Dec 21, 2023
@praveenrewar
Copy link
Member

Transferring the issue to carvel-dev/carvel as it's a docs issue.

@praveenrewar praveenrewar transferred this issue from carvel-dev/kapp-controller Dec 26, 2023
@praveenrewar praveenrewar added good first issue An issue that will be a good candidate for a new contributor documentation This issue indicates a change to the docs should be considered carvel accepted This issue should be considered for future work and that the triage process has been completed and removed carvel-triage labels Dec 26, 2023
@praveenrewar praveenrewar changed the title link "[here](status.usefulErrorMessage)" broken on https://github.com/carvel-dev/carvel/blob/develop/site/content/kapp-controller/docs/develop/debugging-crs.md Broken link in the debugging-crs page in kapp-controller docs Dec 26, 2023
@praveenrewar
Copy link
Member

@tiansiyuan Thanks for opening the issue, would you like to make a contribution for this?

@prashantrewar prashantrewar mentioned this issue Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed documentation This issue indicates a change to the docs should be considered good first issue An issue that will be a good candidate for a new contributor
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update debugging-crs page in kapp-controller docs prashantrewar/carvel
2 participants
@tiansiyuan @praveenrewar