Add fs.FS support to deploy, inspect, diff #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use struct fields as flag defaults. If the flag structs are being filled in programmatically, the values are cleared during flag parsing if the flag defaults differ from the current struct values, which is undesirable. Signed-off-by: Andy Goldstein <[email protected]>
Add fs.FS support to LocalFileSource, FileResource, and the commands that use them (deploy, diff, inspect). This is useful so these commands can be invoked programmatically. Signed-off-by: Andy Goldstein <[email protected]>
|
I am going to take a closer look at this in my daytime tomorrow. I was wondering if you could create an issue illustrating how this change helps and elaborating on your use case? That context would definitely be helpful! |
|
I created #800 for this, thanks! |
There was a problem hiding this comment.
Thank you so much for the PR @ncdc ❤️
Overall it's looking really good (just left some minor comments).
Signed-off-by: Andy Goldstein <[email protected]>
Signed-off-by: Andy Goldstein <[email protected]>
praveenrewar
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
LGTM.
@100mik Let me know if you are planning to take a look at it.
|
Thanks for the PR again! |
github-actions
bot
added
the
carvel triage
praveenrewar
removed
the
carvel triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allow deploy, inspect, and diff to use an
fs.FSfor the filesystem so they can be invoked programmatically with filesystems other than just the normal OS one.Which issue(s) this PR fixes:
Fixes #800
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: