Setting --app-changes-max-to-keep to 0 shouldn't create and delete an app change

[praveenrewar]

What steps did you take:

• Ran kapp deploy -a my-app -f my-file --app-changes-max-to-keep=0 with a user that doesn't have delete permissions on configmaps.
• Ran kapp delete -a my-app with the same user.

What happened:

• App change was created even though I set the cap to 0. If the user has delete permissions, the app change is deleted at the end of deployment.
• kapp delete errors out saying unable to delete the app change as delete permissions are not provided. We want to keep the delete permissions to a minimum, so we can provide delete permissions for the meta configmap based on it's name, but not for the app change, as it uses generatedName.

What did you expect:
I expected kapp to not create an app change when --app-changes-max-to-keep is set to 0.

Anything else you would like to add:

Environment:

• kapp version (use kapp --version):
• OS (e.g. from /etc/os-release):
• Kubernetes version (use kubectl version)

---

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.