Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional ability to check if client has permissions to perform CRUD actions before trying them #855

Closed
ncdc opened this issue Oct 27, 2023 · 3 comments · Fixed by #887
Closed
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request

Comments

@ncdc
Copy link
Contributor

ncdc commented Oct 27, 2023

Describe the problem/challenge you have
When deploying an app, if/when kapp encounters an error, it stops immediately. This can leave the content on the cluster in some intermediate or unknown state.

Describe the solution you'd like
Add an optional setting for kapp to check if the client has permissions to perform every operation needed before executing any of them. If any of the checks fails, kapp makes no modifications to the cluster and returns an error.

Anything else you would like to add:
The SubjectAccessReview API can be used for these checks.

The related kapp-controller issue is carvel-dev/kapp-controller#1381.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@rjtch
Copy link
Contributor

rjtch commented Nov 1, 2023

hey @ncdc and @praveenrewar i would like to work on this task.

@praveenrewar praveenrewar added carvel accepted This issue should be considered for future work and that the triage process has been completed and removed carvel triage This issue has not yet been reviewed for validity labels Nov 4, 2023
@rjtch
Copy link
Contributor

rjtch commented Dec 4, 2023

Hey @praveenrewar @ciriarte what about this ticket?

@praveenrewar
Copy link
Member

@rjtch Apologies, I missed the notification on this one. Feel free work on and create a PR for this and let me know if you need any help with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants