Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved TestAppKindChangeWithMetadataOutput to a separate file #880

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

jignyasamishra
Copy link
Contributor

What this PR does / why we need it:

Moved TestAppKindChangeWithMetadataOutput to a separate file to app_metadata_output_test.go

Which issue(s) this PR fixes:

Fixes #604

Does this PR introduce a user-facing change?

NONE

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@jignyasamishra
Copy link
Contributor Author

Hello @100mik!!! I have made the changes , please have a look. Thank you!!

Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@praveenrewar praveenrewar merged commit 101c28b into carvel-dev:develop Jan 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Move TestAppKindChangeWithMetadataOutput to a separate file
2 participants