You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this really specific for MSv4's created from an MSv2? Probably makes sense for xradio to always create this attribute when it creates an MSv4. Also what should other implementations of the schema do? Add their own attribute? Or would it make sense to have a generic "creator" attribute?
The text was updated successfully, but these errors were encountered:
Related to this, we currently have the schema_version value set in the conversion code. I'd suggest setting the version as a literal string in the MSv4 schema file. This could be simply xradio.measurement_set.schema.version.
xradio_version is currently an optional attribute. I think this new creator attribute should be promoted to required?
Also, more indirectly related to this, there is something about the type parameter (bringing it up here just because it is set in the same group of general attributes when setting the version, etc.): the schema currently lists "visibility" as the only possible type for VisibilityXds, but in practice it can be "visibility" or "wvr" (when WVR intents are present). I think the literal "wvr" should be added to the schema.
Is this really specific for MSv4's created from an MSv2? Probably makes sense for xradio to always create this attribute when it creates an MSv4. Also what should other implementations of the schema do? Add their own attribute? Or would it make sense to have a generic "creator" attribute?
The text was updated successfully, but these errors were encountered: