Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VisibilityXds: xradio_version #332

Open
kettenis opened this issue Nov 25, 2024 · 2 comments
Open

VisibilityXds: xradio_version #332

kettenis opened this issue Nov 25, 2024 · 2 comments

Comments

@kettenis
Copy link
Contributor

Is this really specific for MSv4's created from an MSv2? Probably makes sense for xradio to always create this attribute when it creates an MSv4. Also what should other implementations of the schema do? Add their own attribute? Or would it make sense to have a generic "creator" attribute?

@Jan-Willem
Copy link
Member

I agree we should replace xradio_version with something like:

creator: {software_name: xradio,
version: 1.0.0}

@FedeMPouzols
Copy link
Collaborator

Related to this, we currently have the schema_version value set in the conversion code. I'd suggest setting the version as a literal string in the MSv4 schema file. This could be simply xradio.measurement_set.schema.version.

So is something like this what we want:

...
{
   creator: { software_name: "xradio",
                     version: importlib.metadata.version("xradio")
}
schema_version: measurement_set.schema.version
creation_date: datetime.now(...)
...
}

?

xradio_version is currently an optional attribute. I think this new creator attribute should be promoted to required?

Also, more indirectly related to this, there is something about the type parameter (bringing it up here just because it is set in the same group of general attributes when setting the version, etc.): the schema currently lists "visibility" as the only possible type for VisibilityXds, but in practice it can be "visibility" or "wvr" (when WVR intents are present). I think the literal "wvr" should be added to the schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants