Context
Code review of Layer 1 Part B (devtown#27) flagged two test quality nits.
Issues
1. Test fixture copy-pasted in NaivePrReviewServiceTest
The PrPayload fixture is constructed identically in all three test methods. A @BeforeEach field would eliminate the duplication and make the single test scenario explicit.
2. No @QuarkusTest integration test for PrReviewResource
DevtownBootTest verifies boot and CDI discovery. Nothing exercises POST /api/reviews end-to-end with a real Quarkus context. Jackson serialization of records is untested at the integration level (likely fine given quarkus-rest-jackson is present, but unverified).
A @QuarkusTest with @TestHTTPEndpoint(PrReviewResource.class) should be added before Layer 2 begins adding real implementations.
Refs #27
Context
Code review of Layer 1 Part B (devtown#27) flagged two test quality nits.
Issues
1. Test fixture copy-pasted in NaivePrReviewServiceTest
The
PrPayloadfixture is constructed identically in all three test methods. A@BeforeEachfield would eliminate the duplication and make the single test scenario explicit.2. No
@QuarkusTestintegration test for PrReviewResourceDevtownBootTestverifies boot and CDI discovery. Nothing exercisesPOST /api/reviewsend-to-end with a real Quarkus context. Jackson serialization of records is untested at the integration level (likely fine givenquarkus-rest-jacksonis present, but unverified).A
@QuarkusTestwith@TestHTTPEndpoint(PrReviewResource.class)should be added before Layer 2 begins adding real implementations.Refs #27