Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using arbitrary expressions in confirmation prompt. #1855

Closed
casey opened this issue Jan 18, 2024 Discussed in #1854 · 1 comment
Closed

Allow using arbitrary expressions in confirmation prompt. #1855

casey opened this issue Jan 18, 2024 Discussed in #1854 · 1 comment

Comments

@casey
Copy link
Owner

casey commented Jan 18, 2024

Brought up in #1854. Should be easy enough! The parser should parse an expression instead of a string literal. One question is whether or not the expression should be evaluated with the recipe arguments in scope. An argument in favor of doing this is that it would allow giving more context on what exactly the recipe was doing, an argument against is that it requires evaluating recipe arguments, which you might not want to do unless you're going to run the recipe.

@casey
Copy link
Owner Author

casey commented Dec 11, 2024

Closing in favor of #2521, since that fixes this for all attributes.

@casey casey closed this as completed Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant