-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: group logs when running just in GitHub actions #2480
Comments
Very cool idea! I think we should add it first behind a flag, and then later think about turning it on automatically if Log groups have a start and an end, so I guess we would print out:
Before running a recipe, and:
When the recipe was finished. One thing I'm curious about is what happens if you start a group within another group, which might happen if you recursively invoke
You'd get something like:
Which I'm not sure would display correctly. Here's how I would start with this feature:
|
I was thinking about more granular groups: each recipe line would get its group. Let's try something! Thanks for your quick reply |
Sounds good. We should do whatever is most usable. I don't really know what grouped logs look like, so if giving each recipe line its own group looks good, then that's fine. I suppose it might depend on the commands being run. If a single command generates a bunch of output, then putting it into a group is probably best. However, if there are a bunch of commands run which don't produce much output, then adding each one to a group might not be totally usable. We should probably experiment with both cases to see what works. |
Starting #2482 here! |
Hey!
GitHub supports slightly interactive action output logs: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#grouping-log-lines
It would be cool if just output had these markers when running in GitHub actions, it can be guessed by reading the env var
GITHUB_ACTIONS
, which is expected to be true (doc)Would it be a useful addition to just?
I'd love to contribute this feature but I'm not very familiar with rust, I would need a few hints
The text was updated successfully, but these errors were encountered: