Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kotlin JS npm dependencies #208

Open
hfhbd opened this issue May 18, 2023 · 2 comments
Open

Support Kotlin JS npm dependencies #208

hfhbd opened this issue May 18, 2023 · 2 comments
Labels
enhancement New feature or request PR welcome

Comments

@hfhbd
Copy link
Contributor

hfhbd commented May 18, 2023

Currently, we support Maven coordinates only. Kotlin JS also supports npm dependencies, which would be nice to support too to have one dependency (and spdx) report.
npm stores the license information in the package.json, so parsing these files is easy, it is json and we already uses kotlinx-serialization.

Open question: How to get these files: Could we use Gradle's downloader (somehow)? What about configuration cache? How does KGP fetch the dependencies. AFAIK it is done by yarn during execution (kotlinNodeJsSetup), but we should check it.

(Related, what about cocoapods?)

@JakeWharton
Copy link
Collaborator

Assuming we can get access to the node_modules directory in a stable way, its format is standardized (I think?) and contains all of the package.json files for parsing.

@JakeWharton
Copy link
Collaborator

Presumably also have to depend on whatever task is responsible for running the yarn install.

@JakeWharton JakeWharton added enhancement New feature or request PR welcome labels May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR welcome
Projects
None yet
Development

No branches or pull requests

2 participants