Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreDependenciesByRegex #94

Closed
wants to merge 3 commits into from

Conversation

consp1racy
Copy link
Contributor

Fixes #49.

What's done

  • Implement the thing.
  • Fix running tests on Windows by checking golden text files with LF line endings. violationsIgnored[...] and violationsLogged[...] remain unfixed.
  • installArchives publishes files under ${projectDir}/build where tests expect them, instead of buildDir which, in my case, resides decoupled on a RAM disk.

The tests expect a snapshot version under project directory.
This fixes the case where build directory is moved globally.
Checkout golden text files with LF line endings.
@consp1racy
Copy link
Contributor Author

Any idea how to prevent jitpack from trying to include test maven repos?

https://jitpack.io/com/github/consp1racy/licensee/ep~regex-ignore-1.4.0-gd38f8aa-5/build.log

@JakeWharton
Copy link
Collaborator

Thanks for the PR. I'll review it next week.

The documentation copies `ignoreDependencies` except for sample code.
This follows Gradle's `includeGroupByRegex`.
@ybentlili
Copy link

Hello @JakeWharton any update about this PR ? As I see, it is not yet merged ..

@SmialyKot
Copy link

Any update on this feature?

@consp1racy
Copy link
Contributor Author

I'll have to split it into three separate PRs as outlined above. Then I'll have to resolve the conflicts

@consp1racy consp1racy changed the title Add ignoreDependenciesByRegex Draft: Add ignoreDependenciesByRegex May 19, 2023
@consp1racy consp1racy closed this May 19, 2023
@consp1racy consp1racy changed the title Draft: Add ignoreDependenciesByRegex Add ignoreDependenciesByRegex May 19, 2023
@consp1racy
Copy link
Contributor Author

Gradle 8.1 has this for repository content descriptors, which would fit my needs.

/**
     * Declares that an entire group and its subgroups should be searched for in this repository.
     *
     * <p>
     * A subgroup is a group that starts with the given prefix and has a dot immediately after the prefix.
     * For example, if the prefix is {@code org.gradle}, then {@code org.gradle} is matched as a group,
     * and {@code org.gradle.foo} and {@code org.gradle.foo.bar} are matched as subgroups. {@code org.gradlefoo}
     * is not matched as a subgroup.
     * </p>
     *
     * @param groupPrefix the group prefix to include
     * @since 8.1
     */
    @Incubating
    void includeGroupAndSubgroups(String groupPrefix);

This would be easier than regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for group and module regex matching
4 participants