feat: add deploy page e2e tests #448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thistle-Strum
approved these changes
Jul 10, 2023
test/cypress/e2e/data/mockDeploy.ts
Outdated
| @@ -0,0 +1,10 @@ | |||
| export const mockDeploy = { | |||
There was a problem hiding this comment.
Could you please update this to a function that returns this object? We should get in the habit of only assigning variables for mocks this way.
DorianKwan
reviewed
Jul 18, 2023
| <TransactionGrid gap="2rem"> | ||
| <DetailDataList gap="2rem"> | ||
| {!!deploy?.amount && ( | ||
| <div data-cy="transaction-details-card"> |
There was a problem hiding this comment.
This doesn't mess with any of the existing styling does it?
There was a problem hiding this comment.
No visible style changes. Only did this for testing purposes. Adding the data-cy id on InfoCardContentWrapper did not work.
Comment on lines
+91
to
+98
| <DetailDataLabel>{t('timestamp')}</DetailDataLabel> | ||
| <TransactionDetailData data-testid="readable-time-stamp"> | ||
| {withSkeletonLoading( | ||
| <> | ||
| {deploy?.status} | ||
| <StatusIconWrapper>{statusIcon}</StatusIconWrapper> | ||
| </>, | ||
| deploy?.readableTimestamp, | ||
| isLoading, | ||
| {}, | ||
| )} | ||
| </DeployStatusData> | ||
| </TransactionDetailData> |
There was a problem hiding this comment.
Do we not care about status on desktop?
There was a problem hiding this comment.
Both screens will get status. One is show on HideOnMobile and the other on HideOnDesktop
mgibson-casper
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Summary