Merge #4760

4760: Keep minimum/maximum delegation amounts when updating bids r=fizyk20 a=fizyk20

Currently, the `global-state-update-gen` tool would reset the minimum/maximum delegation amount of any updated bid to `0` and `u64::MAX`, respectively. This PR changes it so that the limits remain unchanged. We should also consider whether we want to be able to specify new limits in an update (currently not possible).


Co-authored-by: Bartłomiej Kamiński <[email protected]>

Author: casperlabs-bors-ng[bot]

utils/global-state-update-gen/src/generic.rs

@@ -308,9 +308,15 @@ pub fn add_and_remove_bids<T: StateReader>(
                     public_key.clone(),
                     *bid.bonding_purse(),
                 ))),
-                BidKind::Validator(validator_bid) => BidKind::Validator(Box::new(
-                    ValidatorBid::empty(public_key.clone(), *validator_bid.bonding_purse()),
-                )),
+                BidKind::Validator(validator_bid) => {
+                    let mut new_bid =
+                        ValidatorBid::empty(public_key.clone(), *validator_bid.bonding_purse());
+                    new_bid.set_delegation_amount_boundaries(
+                        validator_bid.minimum_delegation_amount(),
+                        validator_bid.maximum_delegation_amount(),
+                    );
+                    BidKind::Validator(Box::new(new_bid))
+                }
                 BidKind::Delegator(delegator_bid) => {
                     BidKind::Delegator(Box::new(Delegator::empty(
                         public_key.clone(),
@@ -425,6 +431,8 @@ fn create_or_update_bid<T: StateReader>(
                         *bid.delegation_rate(),
                         delegator_stake,
                     ),
+                    0,
+                    u64::MAX,
                 )
             }
             BidKind::Validator(validator_bid) => {
@@ -444,13 +452,17 @@ fn create_or_update_bid<T: StateReader>(
                         *validator_bid.delegation_rate(),
                         delegator_stake,
                     ),
+                    validator_bid.minimum_delegation_amount(),
+                    validator_bid.maximum_delegation_amount(),
                 )
             }
             _ => unreachable!(),
         });
 
     // existing bid
-    if let Some((bonding_purse, existing_recipient)) = maybe_existing_recipient {
+    if let Some((bonding_purse, existing_recipient, min_delegation_amount, max_delegation_amount)) =
+        maybe_existing_recipient
+    {
         if existing_recipient == *updated_recipient {
             return; // noop
         }
@@ -524,8 +536,8 @@ fn create_or_update_bid<T: StateReader>(
             *bonding_purse,
             *updated_recipient.stake(),
             *updated_recipient.delegation_rate(),
-            0,
-            u64::MAX,
+            min_delegation_amount,
+            max_delegation_amount,
         );
 
         state.set_bid(