Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent CI from running on push and PR creation #439

Closed
devendran-m opened this issue May 13, 2022 · 3 comments
Closed

Prevent CI from running on push and PR creation #439

devendran-m opened this issue May 13, 2022 · 3 comments
Assignees
Labels
L2 won't do The issue will not be worked on

Comments

@devendran-m
Copy link
Contributor

It seems that CI jobs are running twice reacting on on both push and PR creation events when opening a PR, leading to unnecessary resources usage.
Outside that this can lead to confusion and adds us more error surface.
Therefore this ticket aims to prevent CI from running on push and PR creation.

@ipopescu
Copy link
Collaborator

Is this still an issue @bradjohnl ?

@bradjohnl
Copy link
Contributor

@ipopescu I think it is and what I have observed is that if you just specify the push as a trigger for the workflow run, then the checks for the PR do not work because Github Actions is not able to link your last push job status to the PR creation.
There must be a way to deal with this situation.
If a fix is found, you don't have to wait for the jobs to run again on the same commit after opening a PR, when they were successful when the same commit was pushed to your branch.

@ACStone-MTS ACStone-MTS added the won't do The issue will not be worked on label Nov 2, 2023
@ACStone-MTS
Copy link
Contributor

Completed by #1291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L2 won't do The issue will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants