Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows production build fail #101

Open
codams opened this issue May 20, 2021 · 2 comments
Open

Windows production build fail #101

codams opened this issue May 20, 2021 · 2 comments

Comments

@codams
Copy link

codams commented May 20, 2021

Hi there,
I'm having an issue with the production build for windows when following the instruction :
yarn install ✔️
yarn postinstall ✔️
yarn pre-electron-pack ✔️

yarn electron-pack 💔
image

I tried yarn electron-builder build --dir --windows ✔️ !

Then I am stuck when trying yarn electron .

The build looks like this :
image

It's missing some parts ? I tried remote debugging but it shows me the same empty document 😢

Might be related to #82 ?

I have never used electron so I might be the issue 🦕

I am on a classic 64 bits windows 10 - build 19042

@codams
Copy link
Author

codams commented Jun 1, 2021

Some follow up if anyone has the same issue :
I went for making it work in dev env first and I had the same result but now it's working 🦊

You need to
npm install --save cross-env
Then add cross-env before BROWSER in the electron-dev command like :
concurrently \"cross-env BROWSER=none yarn start\" \"wait-on http://localhost:3000 && electron .\"

After this, it works fine in a dev environment !

@cassidoo I can try on a Linux machine (and windows oc) but I can't get access to a Mac, should I make a PR and let someone else try on a mac ?

Have a great sunny day all ! ✨

@cassidoo
Copy link
Owner

cassidoo commented Jun 1, 2021

Oh, excellent! Thanks for figuring that out! I can test it out on a Mac if you make a PR! Thank you so much for testing Linux, that's the OS I don't have 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants