SourceDocument should provide method for vector #2661
Comments
vincent-4
pushed a commit
to vincent-4/anserini
that referenced
this issue
Dec 25, 2024
…method with default null implementation - Update vector document generators to use vector() with string fallback - Addresses inefficient vector-to-string conversion pattern - See: castorini#2661
vincent-4
pushed a commit
to vincent-4/anserini
that referenced
this issue
Dec 25, 2024
…method with default null implementation - Update vector document generators to use vector() with string fallback - Addresses inefficient vector-to-string conversion pattern - See: castorini#2661
vincent-4
pushed a commit
to vincent-4/anserini
that referenced
this issue
Dec 25, 2024
…method with default null implementation - Update vector document generators to use vector() with string fallback - Addresses inefficient vector-to-string conversion pattern - See: castorini#2661
|
@vincent-4 how is this going? |
|
I've done most of the implementations– just have to do a sanity check with the tests (existing, maybe add some new ones.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently,
SourceDocumentonly providescontents()which returns a String.This means that for dense vectors, we first convert into a string and then parse back into a vector... which is silly.
We should add something like
The text was updated successfully, but these errors were encountered: