Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(context): context id is an int, value is a str #629

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix(context): context id is an int, value is a str #629

merged 1 commit into from
Jul 10, 2023

Conversation

jefflembeck
Copy link
Contributor

@jefflembeck jefflembeck commented Jul 10, 2023 •
edited
Loading

This makes sure both are strings

Fixes #623

@jefflembeck
fix(context): context id is an int, value is a str
5421a7b 
This makes sure both are strings
@jefflembeck jefflembeck requested a review from pmeenan July 10, 2023 20:27
pmeenan
pmeenan approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@pmeenan pmeenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@jefflembeck jefflembeck merged commit 148f635 into master Jul 10, 2023
@jefflembeck jefflembeck deleted the iframe-id-context branch July 10, 2023 21:36
jefflembeck added a commit that referenced this pull request Jul 11, 2023
@jefflembeck
fix(context): context id is an int, value is a str (#629)
5e17337 
This makes sure both are strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeenan pmeenan pmeenan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to set the executionContext using Id of iframe
2 participants
@jefflembeck @pmeenan