{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":629041066,"defaultBranch":"main","name":"pytorch","ownerLogin":"cattidea","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-04-17T13:53:05.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/58100262?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1682555173.0","currentOid":""},"activityList":{"items":[{"before":"54b0006cb232f798281397b2261101625444c79b","after":"ea47d542ca36005372139921d18b5763d9bcd295","ref":"refs/heads/main","pushedAt":"2024-06-20T14:41:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"SigureMo","name":"Nyakku Shigure","path":"/SigureMo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38436475?s=80&v=4"},"commit":{"message":"[dynamo][guards] Remove BOOL_FALSE - not needed after C++ guards (#129098)\n\nPyDict_Size is very fast ... earlier with Python guards, Cpython will go through layers of fluff to finally call the PyDict_Size. With C++ guards, its not needed.\n\nPull Request resolved: https://github.com/pytorch/pytorch/pull/129098\nApproved by: https://github.com/jansel","shortMessageHtmlLink":"[dynamo][guards] Remove BOOL_FALSE - not needed after C++ guards (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2363258141\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pytorch/pytorch/issues/129098\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pytorch/pytorch/pull/129098/hovercard\" href=\"https://github.com/pytorch/pytorch/pull/129098\">pyt…</a>"}},{"before":"d61a81a9e76688ac8f338a6cfba932bf7779e5ce","after":"54b0006cb232f798281397b2261101625444c79b","ref":"refs/heads/main","pushedAt":"2024-06-20T14:18:45.000Z","pushType":"push","commitsCount":1509,"pusher":{"login":"SigureMo","name":"Nyakku Shigure","path":"/SigureMo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38436475?s=80&v=4"},"commit":{"message":"Evaluate symexprs on load path of cache not write (#128997)\n\nWhen caching is enabled, an internal model fails with\n```\nassert_size_stride(bmm_9, (17, s0, 512), (54784, 512, 1))\nAssertionError: expected size 17==17, stride 57344==54784 at dim=0\n```\nlooking at this model, the exact problem is when the cache is hit on the forward graph, the generated code for backward fails since the strides of the outputs of forward, passed to backward as inputs, are not what we expected.\n\nThis PR changes the evaluation logic so that we defer evaluation of output stride exprs to load path as opposed to eagerly doing it on save path.\n\nI have not been able to come up with a unit test repro for this problem.\n\nDifferential Revision: [D58796503](https://our.internmc.facebook.com/intern/diff/D58796503)\nPull Request resolved: https://github.com/pytorch/pytorch/pull/128997\nApproved by: https://github.com/ezyang","shortMessageHtmlLink":"Evaluate symexprs on load path of cache not write (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2360685009\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pytorch/pytorch/issues/128997\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pytorch/pytorch/pull/128997/hovercard\" href=\"https://github.com/pytorch/pytorch/pull/128997\">pytorch#128997</a>)"}},{"before":"6ce3a380508433a6c452e470d07d7705961825b6","after":"d61a81a9e76688ac8f338a6cfba932bf7779e5ce","ref":"refs/heads/main","pushedAt":"2024-05-16T06:22:42.000Z","pushType":"push","commitsCount":8064,"pusher":{"login":"SigureMo","name":"Nyakku Shigure","path":"/SigureMo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38436475?s=80&v=4"},"commit":{"message":"Fix lint failures coming from #126035 (#126378)\n\nMYPY somehow shows lots of local failures for me.  The issue is tracked in https://github.com/pytorch/pytorch/issues/126361.  This is only to keep trunk sane.  These two line were added by #126035 as an attempt to fix lint there, but didn't seem to help.\n\nPull Request resolved: https://github.com/pytorch/pytorch/pull/126378\nApproved by: https://github.com/kit1980","shortMessageHtmlLink":"Fix lint failures coming from <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2291553019\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pytorch/pytorch/issues/126035\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pytorch/pytorch/pull/126035/hovercard\" href=\"https://github.com/pytorch/pytorch/pull/126035\">pytorch#126035</a> (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2299321963\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pytorch/pytorch/issues/126378\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pytorch/pytorch/pull/126378/hovercard\" href=\"https://github.com/pytorch/pytorch/pull/126378\">pytorch#126378</a>)"}},{"before":"a867e6db85309d988cd8a0305c5c323df2737f9b","after":"6ce3a380508433a6c452e470d07d7705961825b6","ref":"refs/heads/main","pushedAt":"2023-10-12T04:59:48.000Z","pushType":"push","commitsCount":4140,"pusher":{"login":"SigureMo","name":"Nyakku Shigure","path":"/SigureMo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38436475?s=80&v=4"},"commit":{"message":"Revert \"Move export.constrain_as_* to torch._constrain_as_* (#110757)\"\n\nThis reverts commit 5aee22e0e033dbd2346b533fb2651ee30ca5ed86.\n\nReverted https://github.com/pytorch/pytorch/pull/110757 on behalf of https://github.com/kit1980 due to Depends on https://github.com/pytorch/pytorch/pull/109859 that needs to be reverted ([comment](https://github.com/pytorch/pytorch/pull/110757#issuecomment-1758908371))","shortMessageHtmlLink":"Revert \"Move export.constrain_as_* to torch._constrain_as_* (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1930877346\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pytorch/pytorch/issues/110757\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pytorch/pytorch/pull/110757/hovercard\" href=\"https://github.com/pytorch/pytorch/pull/110757\">pytorch#…</a>"}},{"before":"3f5d768b561e3edd17e93fd4daa7248f9d600bb2","after":"a867e6db85309d988cd8a0305c5c323df2737f9b","ref":"refs/heads/main","pushedAt":"2023-06-06T17:23:21.930Z","pushType":"push","commitsCount":1435,"pusher":{"login":"SigureMo","name":"Nyakku Shigure","path":"/SigureMo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38436475?s=80&v=4"},"commit":{"message":"Add newline before minified repro path (#103083)\n\nMinor QOL change.  This log message is pushed into my history by the\nbacktrace, which is a pain because if I tab up in tmux I can no longer\npaste it without line breaks.  This makes it more convenient to use tmux\ncopy mode to get only the file (as I get the entire line this way.)\n\nSigned-off-by: Edward Z. Yang <ezyang@meta.com>\n\nPull Request resolved: https://github.com/pytorch/pytorch/pull/103083\nApproved by: https://github.com/albanD","shortMessageHtmlLink":"Add newline before minified repro path (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1743916052\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pytorch/pytorch/issues/103083\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pytorch/pytorch/pull/103083/hovercard\" href=\"https://github.com/pytorch/pytorch/pull/103083\">pytorch#103083</a>)"}},{"before":"14c3eb7fb6708b7cede6bb49ed05f7b8dee72f25","after":"3f5d768b561e3edd17e93fd4daa7248f9d600bb2","ref":"refs/heads/main","pushedAt":"2023-04-27T01:22:38.000Z","pushType":"push","commitsCount":100,"pusher":{"login":"SigureMo","name":"Nyakku Shigure","path":"/SigureMo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38436475?s=80&v=4"},"commit":{"message":"Refactors/improvements in _inductor/fx_passes (#100063)\n\nPull Request resolved: https://github.com/pytorch/pytorch/pull/100063\nApproved by: https://github.com/devashishshankar","shortMessageHtmlLink":"Refactors/improvements in _inductor/fx_passes (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1684261238\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pytorch/pytorch/issues/100063\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pytorch/pytorch/pull/100063/hovercard\" href=\"https://github.com/pytorch/pytorch/pull/100063\">pytorch#100063</a>)"}},{"before":"99f2180e429678047a559fb7c8efd3161b345597","after":null,"ref":"refs/heads/unnecessary-if-expr","pushedAt":"2023-04-27T00:26:13.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"SigureMo","name":"Nyakku Shigure","path":"/SigureMo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38436475?s=80&v=4"}},{"before":"c9c30e8e47c49bd1b6c9847af3de10b2a90704f6","after":"99f2180e429678047a559fb7c8efd3161b345597","ref":"refs/heads/unnecessary-if-expr","pushedAt":"2023-04-25T16:03:33.000Z","pushType":"push","commitsCount":370,"pusher":{"login":"SigureMo","name":"Nyakku Shigure","path":"/SigureMo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38436475?s=80&v=4"},"commit":{"message":"Merge branch 'main' into unnecessary-if-expr","shortMessageHtmlLink":"Merge branch 'main' into unnecessary-if-expr"}},{"before":"1e8cf6ad7f7ffc8e16403f975faa3c209b5acb41","after":"14c3eb7fb6708b7cede6bb49ed05f7b8dee72f25","ref":"refs/heads/main","pushedAt":"2023-04-25T16:03:08.000Z","pushType":"push","commitsCount":61,"pusher":{"login":"SigureMo","name":"Nyakku Shigure","path":"/SigureMo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38436475?s=80&v=4"},"commit":{"message":"[Testing] flip switch, remove slow path assertions (#99101)\n\nPull Request resolved: https://github.com/pytorch/pytorch/pull/99101\nApproved by: https://github.com/bdhirsh","shortMessageHtmlLink":"[Testing] flip switch, remove slow path assertions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1667247141\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pytorch/pytorch/issues/99101\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pytorch/pytorch/pull/99101/hovercard\" href=\"https://github.com/pytorch/pytorch/pull/99101\">pytorch#99101</a>)"}},{"before":"6e3cdcad08f2955117cc5757bdb7bcc7387ac355","after":"1e8cf6ad7f7ffc8e16403f975faa3c209b5acb41","ref":"refs/heads/main","pushedAt":"2023-04-24T08:13:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"SigureMo","name":"Nyakku Shigure","path":"/SigureMo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38436475?s=80&v=4"},"commit":{"message":"Add documentation for `torch._logging.set_logs` (#99219)\n\nPart of #98871\n\nPull Request resolved: https://github.com/pytorch/pytorch/pull/99219\nApproved by: https://github.com/mlazos, https://github.com/lezcano","shortMessageHtmlLink":"Add documentation for <code>torch._logging.set_logs</code> (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1669119659\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pytorch/pytorch/issues/99219\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pytorch/pytorch/pull/99219/hovercard\" href=\"https://github.com/pytorch/pytorch/pull/99219\">pytorch#99219</a>)"}},{"before":"ed5395dbef01c796819ae21421b9389d8c89edb9","after":"6e3cdcad08f2955117cc5757bdb7bcc7387ac355","ref":"refs/heads/main","pushedAt":"2023-04-24T08:05:15.000Z","pushType":"push","commitsCount":307,"pusher":{"login":"SigureMo","name":"Nyakku Shigure","path":"/SigureMo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38436475?s=80&v=4"},"commit":{"message":"Fix flake8 lint errors - part 2 - manual fixes (#99799)\n\n<!--\ncopilot:all\n-->\n### <samp>🤖 Generated by Copilot at 8aef78f</samp>\n\n### Summary\n📝🚀🛠️\n\n<!--\n1.  📝 for modifying the logging format and style\n2.  🚀 for improving performance and avoiding unnecessary string creation\n3.  🛠️ for fixing flake8 issues\n-->\nThis pull request updates some logging calls to use old-style string formatting with `%s` placeholders instead of f-strings in `torch/_dynamo/logging.py`, `torch/_functorch/compilers.py`, and `torch/fx/passes/pass_manager.py` as part of a logging standardization effort. It also adds a `# noqa: F404` comment to the `import __future__` statement in `torch/overrides.py` to fix a flake8 warning.\n\n> _`log` uses old style_\n> _formatting strings with `%s`_\n> _logging is faster_\n\n### Walkthrough\n*  Standardize logging format and style to use old-style string formatting with `%s` placeholders instead of f-string syntax for performance and consistency ([link](https://github.com/pytorch/pytorch/pull/99799/files?diff=unified&w=0#diff-18807f7fd187b8bc8e69e93722566195b36d5bf269099b415a6f90b552228d6bL55-R55), [link](https://github.com/pytorch/pytorch/pull/99799/files?diff=unified&w=0#diff-fae8a66564055743ec031edb87eb22edeebf7fdebef9d21660d5e6a6252e5222L370-R373), [link](https://github.com/pytorch/pytorch/pull/99799/files?diff=unified&w=0#diff-5f3e37ded032f24e247dcf4a3be4b73ea0cf21382e342631742e5a04550202e1L72-R72))\n*  Suppress flake8 warning for `import __future__` statement in `torch/overrides.py` with `# noqa: F404` comment ([link](https://github.com/pytorch/pytorch/pull/99799/files?diff=unified&w=0#diff-4f601fe7f31e875ee4354882c0bb490bc35e51d3d413d058cc5fda3be8ca9f15L23-R23))\n\nPull Request resolved: https://github.com/pytorch/pytorch/pull/99799\nApproved by: https://github.com/Skylion007","shortMessageHtmlLink":"Fix flake8 lint errors - part 2 - manual fixes (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1679615065\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pytorch/pytorch/issues/99799\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pytorch/pytorch/pull/99799/hovercard\" href=\"https://github.com/pytorch/pytorch/pull/99799\">pytorch#99799</a>)"}},{"before":null,"after":"c9c30e8e47c49bd1b6c9847af3de10b2a90704f6","ref":"refs/heads/unnecessary-if-expr","pushedAt":"2023-04-24T08:04:42.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"SigureMo","name":"Nyakku Shigure","path":"/SigureMo","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/38436475?s=80&v=4"},"commit":{"message":"[pt2] remove unnecessary if expr","shortMessageHtmlLink":"[pt2] remove unnecessary if expr"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEaq3sYAA","startCursor":null,"endCursor":null}},"title":"Activity · cattidea/pytorch"}