Integration into mainline

[dcramer]

I started adding functionality like this to Sentry's core.

Currently there's three things that I've done:

• Each frame can have an "in_app" attribute, defaults to True. System frames (e.g. rails framework) would ideally be set to false.
• The stacktrace interface will hide all system frames, assuming there is > 0 app frames, and has a checkbox to show hidden frames.
• Checksums have changed so that stacktraces are now (in ideal scenarios) filename + line of context (vs function name)

Do you think there's any additional features we may need? I like the idea of cleaned function name, but maybe it'd be more ideal if we just allowed things to pass a contextual id somehow. I'm not entirely sure its still needed though.

[dcramer]

I like the context_type idea as well, and maybe its superior (and fits better) than the in_app stuff. We haven't technically released 5.1 which includes in_app so if it's worth the switch we could still make that happen.

[noahsilas]

in_app should be sufficient for everything that we were using context_type for. In theory we could also differentiate things like the framework from plugins/extensions/whatever, so the question is, would using a context_type allow for future extensibility without causing too much of a problem in 5.1. I personally like it, but not enough to really fight for it.

[noahsilas]

The cleaned function name is pretty important to our use case here at Causes, mostly because we have an extension that does evil meta-programming and injects frames with a name that is dynamically generated. This causes tracebacks for the same error that have different hashes. Granted this is fairly obscure, so we understand we may need to keep using an extension like this.