You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed we aren't following semantic rules for HTML code on the website. We don't have an h1 tag on the homepage and we're incorrectly using h3 tags for 'paragraphs'. Here are a couple of instances I noticed
The main heading of the website needs to be an <h1> tag but it's an <h2> tag <h2 class="home-tagline"> Making India's Budgets open, usable and easy to comprehend</h2>
We're using <h3> tags for 'paragraphs'; we should be using the <p> tag here
Given this, I'm assuming there might be more instances where we're not following the rules. Let me know if you want to do a code walk-through together and fix them.
The text was updated successfully, but these errors were encountered:
@vrnpi Sure we can sit for this but this we can take bit slower as it is there in the existing code, I am trying not to change existing HTML so we have the result. I will update about the progress on this.
We've changed a lot of code on the home page for some of the other components (like 'key features', 'budget basics', 'dashboards', etc.) so why can't we include it our scope, change, and push out something we know is not right. It would make the code more maintainable and rest assured we'll be setting a good precedent for future releases.
I noticed we aren't following semantic rules for HTML code on the website. We don't have an
h1
tag on the homepage and we're incorrectly usingh3
tags for 'paragraphs'. Here are a couple of instances I noticedThe main heading of the website needs to be an
<h1>
tag but it's an<h2>
tag<h2 class="home-tagline"> Making India's Budgets open, usable and easy to comprehend</h2>
We're using
<h3>
tags for 'paragraphs'; we should be using the<p>
tag hereGiven this, I'm assuming there might be more instances where we're not following the rules. Let me know if you want to do a code walk-through together and fix them.
The text was updated successfully, but these errors were encountered: