Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic code for content #78

Open
vrnpi opened this issue Nov 11, 2020 · 2 comments
Open

Semantic code for content #78

vrnpi opened this issue Nov 11, 2020 · 2 comments

Comments

@vrnpi
Copy link

vrnpi commented Nov 11, 2020

I noticed we aren't following semantic rules for HTML code on the website. We don't have an h1 tag on the homepage and we're incorrectly using h3 tags for 'paragraphs'. Here are a couple of instances I noticed

  • The main heading of the website needs to be an <h1> tag but it's an <h2> tag
    <h2 class="home-tagline"> Making India's Budgets open, usable and easy to comprehend</h2>

  • We're using <h3> tags for 'paragraphs'; we should be using the <p> tag here

<div class="banner-description">
    <h3 class="homepage-section-text">
         ...
    </h3>
</div>

Given this, I'm assuming there might be more instances where we're not following the rules. Let me know if you want to do a code walk-through together and fix them.

@shivamragnar
Copy link
Member

@vrnpi Sure we can sit for this but this we can take bit slower as it is there in the existing code, I am trying not to change existing HTML so we have the result. I will update about the progress on this.

@vrnpi
Copy link
Author

vrnpi commented Nov 11, 2020

@shivamragnar I don't understand.

We've changed a lot of code on the home page for some of the other components (like 'key features', 'budget basics', 'dashboards', etc.) so why can't we include it our scope, change, and push out something we know is not right. It would make the code more maintainable and rest assured we'll be setting a good precedent for future releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants