Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: configure error reporting and notifications #180

Open
2 tasks
hannahle opened this issue Jan 31, 2022 · 1 comment
Open
2 tasks

Node: configure error reporting and notifications #180

hannahle opened this issue Jan 31, 2022 · 1 comment

Comments

@hannahle
Copy link
Collaborator

hannahle commented Jan 31, 2022

  • Create a design proposal on how to log errors, queries and send notifications. The document should explain the context and aims of this feature, as well as proposed solutions and the rationale behind them. Please send the document in #osmp team channel for feedback before starting implementation.
  • More action items to be added after step 1 above.
@hannahle hannahle added the high priority Urgent bug fixes or highly requested features that should be worked on first label Feb 2, 2022
@jennyziyi-xu jennyziyi-xu self-assigned this Mar 16, 2022
@jennyziyi-xu
Copy link
Collaborator

Next steps in order

  • Logging for ssmp-server, design proposal and implementation
  • Logging for react, design proposal and implementation
  • MongoDB query logging, design proposal and implementation
  • Send notification to CCM developers (Slack preferred or MS teams), design proposal and implementation
  • Audit test-node logging

React
Current status:

  • A context handles network errors, server errors, node errors for displaying errors on GUI.
  • No console.log()

To Do:

  • Audit if context handles network error correctly. Server not available error is not handled correctly. When we have this
    createHttpLink.ts:156 POST http://localhost:6845/graphql 500 (Internal Server Error)
    This error is not displayed but instead timeout error is displayed
  • Add serviceWorker to enable offline experience?
  • Add console.log to indicate key steps for the developers, separate into Info, Debug, Error

Server
Current status:

  • Winston is used for logging, logger.info(), logger.error()
  • We log errors from fetching data from G4RD and remote node.

To Do:

  • Add more error logging for Cadd and Gnomad fetch?

Test-node
Current status:

  • Error logging is put in place.

To Do:

  • Audit

MongoDB Query Logging
To Do:

  • Find a way to turn off mongodb logs with an env variable?

Important errors to handle:

  • ssmp-server is not available.
  • ssmp-server is available but data node(s) are not available such as remote-test or g4rd
  • We can't get variant data, we can't display anything in the result table.
  • We get variant data, we can't get Caddannotation
  • We only annotate with gnomad, and display error message Caddannotation is not available.
  • We get variant data, Caddannotation, but can't get gnomad annotations because problem minio
  • Only annotate with caddannotation, display error message gnomad not available.

@jennyziyi-xu jennyziyi-xu removed the high priority Urgent bug fixes or highly requested features that should be worked on first label Mar 23, 2022
@jennyziyi-xu jennyziyi-xu removed their assignment Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants