Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all reference to obsolete IConfigurationSectionHandler #308

Open
savornicesei opened this issue Feb 18, 2021 · 0 comments
Open

Remove all reference to obsolete IConfigurationSectionHandler #308

savornicesei opened this issue Feb 18, 2021 · 0 comments

Comments

@savornicesei
Copy link
Contributor

See comment on PR #306

Changing the code to follow today's standards allows to get an instance of XslFilesSectionHandler returned by GetSection and as such access any code on it that could return a list of strings as expected by users of this section.

Note that there is another location where GetSection is called, inside CruiseServerFactory.CreateLocal, along with the ServerConfigurationHandler section handler that implements IConfigurationSectionHandler. I believe the same set of changes is required there as well.

There is one last usage of IConfigurationSectionHandler, and it's in CruiseControlConfigSectionHandler. But I don't understand its usage as its Create method returns null in all cases. Maybe it should just be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant