Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with recent versions of Anki #39

Open
rwmpelstilzchen opened this issue Dec 15, 2021 · 13 comments
Open

Compatibility with recent versions of Anki #39

rwmpelstilzchen opened this issue Dec 15, 2021 · 13 comments

Comments

@rwmpelstilzchen
Copy link

rwmpelstilzchen commented Dec 15, 2021

Dear @ccz-2,

The problem with versions >2.1.45 of Anki (whatever it was) seems to be solved in later versions. Changing the version limit meta.json allows users to use the add-on without any problems, apart from the need to change the file every once in a while (Anki resets it). Since there has been no reaction on your side regarding this issue¹, I think about creating a fork with correct meta.json information. As the add-on works fine, this suboptimal solution can be easily avoided by you updating the add-on so it will not be automatically disabled by Anki.

With great appreciation to the work you have done,
Júda

¹ I hope you are well and there is no external issue (e.g. health) that prevents you from updating the add-on. If there is, I hope everything gets better soon ^_^

@GauthierHq
Copy link

I does not work indeed.

rwmpelstilzchen : could you let me know how I can use your branch to make it work? I have never used Github but it seems that I can't just download your branch and use an installer within it (there is none). Could you help me with a way to make this work? I have no knowledge in code or Github.

@GauthierHq
Copy link

Dear @ccz-2,

The problem with versions >2.1.45 of Anki (whatever it was) seems to be solved in later versions. Changing the version limit meta.json allows users to use the add-on without any problems, apart from the need to change the file every once in a while (Anki resets it). Since there has been no reaction on your side regarding this issue¹, I think about creating a fork with correct meta.json information. As the add-on works fine, this suboptimal solution can be easily avoided by you updating the add-on so it will not be automatically disabled by Anki.

With great appreciation to the work you have done, Júda

¹ I hope you are well and there is no external issue (e.g. health) that prevents you from updating the add-on. If there is, I hope everything gets better soon ^_^

@rwmpelstilzchen

@GauthierHq
Copy link

I managed to make it work in the end.
It is a fantastic add-on!

@Jonas-Ste
Copy link

I managed to make it work in the end. It is a fantastic add-on!

Would you mind briefly sharing the steps to compile the addon from the branch of @rwmpelstilzchen ?

@jwdevelab
Copy link

I managed to make it work in the end. It is a fantastic add-on!

How?

@Jonas-Ste
Copy link

I managed to make it work in the end. It is a fantastic add-on!

How?

Go to her/his fork: https://github.com/rwmpelstilzchen/No-Distractions-Full-Screen
Click the "Code" button and download everything as a zip-file. Extract the folder after downloading.
Copy the extracted folder (by default it's named "No-Distractions-Full-Screen-master" but any foldername without spaces will work) to where Anki-Addons are stored (for me that's C:\Users\Jonas\AppData\Roaming\Anki2\addons21). You can find out by going to the Addon-settings in Anki and click "View files". Restart Anki after copying and the addon should appear in your addon overview.

@ghost
Copy link

ghost commented Jan 26, 2022

I managed to make it work in the end. It is a fantastic add-on!

How?

Go to her/his fork: https://github.com/rwmpelstilzchen/No-Distractions-Full-Screen Click the "Code" button and download everything as a zip-file. Extract the folder after downloading. Copy the extracted folder (by default it's named "No-Distractions-Full-Screen-master" but any foldername without spaces will work) to where Anki-Addons are stored (for me that's C:\Users\Jonas\AppData\Roaming\Anki2\addons21). You can find out by going to the Addon-settings in Anki and click "View files". Restart Anki after copying and the addon should appear in your addon overview.

Man, I got it! thank you so much! I just honestly made an account just to thank you LOL! thanks again. The thing was I did not know where to download the code, and you gave it with the instructions as well! That's amazingly insane!

@hsusanoo
Copy link

hsusanoo commented Jan 29, 2022

I managed to make it work in the end. It is a fantastic add-on!

How?

@jwdevelab You can also just download NDFS.ankiaddon file from that fork and open it directly with Anki.

@mobedoor
Copy link

mobedoor commented Mar 5, 2022

2.1.50 beta 4 seems to break addon functionality even with rwmpelstilzchen's fork.

@mobedoor
Copy link

Issue seemed to be with toolbar.py. Luckily I found an updated version of the same in another addon by @ijgnd. I forked and updated the ankiaddon file here. I'm not a coder so I can't offer any support. It works for me on Linux.

This was referenced Apr 20, 2022
@rwmpelstilzchen
Copy link
Author

@mobedoor: Great to hear! Thanks 🙂

This repo and the corresponding page on AnkiWeb don’t seem to be maintained anymore. Do you want to make your fork available on AnkiWeb, so people will be able to install it easily?

I suggest enabling issues on GitHub. I have a small issue to submit (NDFS doesn’t play well with Anki Zoom on 2.1.50, because Anki Zoom doesn’t work well on 2.1.50…).

@mobedoor
Copy link

@rwmpelstilzchen Replied to you on the Anki Zoom page. I'll check to see if I can open issues, but again, not a coder so I can't offer much support.

@rwmpelstilzchen
Copy link
Author

Thanks! :-)

Issues are of course not just for support. They can be a place to discuss certain... well... issues, which can result in other people offering pull requests for solving them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants