Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNIME 4.6 node build fails dependency checker #20

Open
webbres opened this issue Jun 17, 2022 · 4 comments
Open

KNIME 4.6 node build fails dependency checker #20

webbres opened this issue Jun 17, 2022 · 4 comments

Comments

@webbres
Copy link
Contributor

webbres commented Jun 17, 2022

Raising here for visibility.

KNIME community builds now have OWASP dependency checker run against them and fail on critical security issues.

Legacy CDK fails on:

The KNIME plugin has a bundled jar for CDK 1.5.13 so it's not possible to simply replace the libs provided.

For the reaction decoder tool integration I updated the dependencies (CDK 2.4 -> 2.7) and then had to update some of the CDK dependencies to work around security issues.

I'll try submit a fix for this, will need to make sure CDK 1.5 tests pass with updated JENA deps

@egonw
Copy link
Member

egonw commented Jun 17, 2022

Yes, update to CDK 2.7.1 is really needed. Let's see how far we get with https://github.com/cdk/nodes4knime-cdk2

@egonw
Copy link
Member

egonw commented Jun 19, 2022

I have now pushed a patch that make the "fork" compile with the CDK 2.7.1. The next two weeks I will not have time to work on it. Continuation of the patch is most welcome, e.g. to restore AMBIT and Jmol functionality. Restoring the JChemPaint functionality is a lot harder. Last year I already tried updating JChemPaint to the latest CDK version, but unsuccesfully.

@webbres
Copy link
Contributor Author

webbres commented Jun 19, 2022

I'll take a look and see if I can progress it.

@webbres
Copy link
Contributor Author

webbres commented Jun 23, 2022

FYI I've started looking at continuing the CDK upgrade on this fork: https://github.com/webbres/nodes4knime-cdk2/tree/cdk2-upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants