Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SmartCyp to CDK 2.9 (or better) #22

Open
tdudgeon opened this issue Jan 15, 2024 · 12 comments
Open

update SmartCyp to CDK 2.9 (or better) #22

tdudgeon opened this issue Jan 15, 2024 · 12 comments
Assignees
Labels

Comments

@tdudgeon
Copy link

SmartCyp uses the 1.4 API and 1.5+ can't be used.
https://smartcyp.sund.ku.dk/mol_to_som

@egonw
Copy link
Member

egonw commented Jan 15, 2024

Source code: http://smartcyp2.sund.ku.dk/download.php

@egonw egonw added the WP2 label Feb 20, 2024
@egonw
Copy link
Member

egonw commented Apr 4, 2024

Also needs JChemPaint.

Also needs the JChemPaint-originating rendering stack, but that is actually part of the CDK.

@egonw
Copy link
Member

egonw commented Apr 4, 2024

Downstream users: Bioclipse (Bacting!) and this: https://github.com/christinadebruynkops/GLORYx/tree/a1f4a8246e09eb971aac88d29123f59f2ad33944

@egonw
Copy link
Member

egonw commented Apr 4, 2024

We're running into character encoding issues:

[ERROR] /home/egonw/var/Projects/Other/smartcyp/src/main/java/smartcyp/MoleculeKU.java:[1084,118] unmappable character (0x96) for encoding UTF-8
[ERROR] /home/egonw/var/Projects/Other/smartcyp/src/main/java/smartcyp/MoleculeKU.java:[1084,1388] unmappable character (0x96) for encoding UTF-8
[ERROR] /home/egonw/var/Projects/Other/smartcyp/src/main/java/smartcyp/MoleculeKU.java:[1088,140] unmappable character (0x96) for encoding UTF-8
[ERROR] /home/egonw/var/Projects/Other/smartcyp/src/main/java/smartcyp/MoleculeKU.java:[1092,120] unmappable character (0x96) for encoding UTF-8
[ERROR] /home/egonw/var/Projects/Other/smartcyp/src/main/java/smartcyp/MoleculeKU.java:[1096,515] unmappable character (0x96) for encoding UTF-8

@jmillanacosta
Copy link

jmillanacosta commented Apr 4, 2024

@egonw
Copy link
Member

egonw commented Apr 6, 2024

@egonw
Copy link
Member

egonw commented Apr 6, 2024

Update to CDK 2.1 fails with a missing dependency:

[ERROR] Failed to execute goal on project smartcyp: Could not resolve dependencies for project io.github.cdk.smartcyp:smartcyp:jar:2.5.0-SNAPSHOT: The following artifacts could not be resolved: uk.ac.ebi.beam:beam-core:jar:1.1-SNAPSHOT, uk.ac.ebi.beam:beam-func:jar:1.1-SNAPSHOT: Could not find artifact uk.ac.ebi.beam:beam-core:jar:1.1-SNAPSHOT in ossrh (https://oss.sonatype.org/content/repositories/snapshots) -> [Help 1]

@egonw
Copy link
Member

egonw commented Apr 6, 2024

Update to CDK 2.2 fails with the following, which will be fixed when I further clean up the use of builders and a single (silent?) data model implementation:

Exception in thread "main" java.lang.ClassCastException: class org.openscience.cdk.AtomContainer2$BaseAtomRef cannot be cast to class org.openscience.cdk.Atom (org.openscience.cdk.AtomContainer2$BaseAtomRef and org.openscience.cdk.Atom are in unnamed module of loader 'app')
        at smartcyp.MoleculeKU.assignAtomEnergies(MoleculeKU.java:229)
        at smartcyp.SMARTCyp.main(SMARTCyp.java:210)

@egonw
Copy link
Member

egonw commented Apr 6, 2024

Okay, I got it compiling with CDK 2.9 and the calculations seem to run okay, but the rendering worked still okay with 2.2 but is not ideal with 2.9:

image

@egonw egonw self-assigned this Apr 6, 2024
@egonw
Copy link
Member

egonw commented Apr 6, 2024

Task: #26

@egonw
Copy link
Member

egonw commented Apr 7, 2024

@tdudgeon, this would be a good time to give the new a first spin.

@egonw
Copy link
Member

egonw commented Jun 16, 2024

Look up past code examples: #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants