Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uglify-es/uglify-js, use terser #250

Open
MattIPv4 opened this issue Feb 15, 2022 · 1 comment
Open

Remove uglify-es/uglify-js, use terser #250

MattIPv4 opened this issue Feb 15, 2022 · 1 comment

Comments

@MattIPv4
Copy link
Member

MattIPv4 commented Feb 15, 2022 •
edited
Loading

It looks like uglify-es has been deprecated on NPM. Further, terser seems to a more common tool used for compressing JS assets, so we should replace uglify-js with it.

Hopefully this may also resolve issues seen with newer syntax such as top-level await (https://github.com/cdnjs/packages/runs/5103276658?check_suite_focus=true), and issues with bad compression of libraries (cdnjs/packages#1363).
@MattIPv4 MattIPv4 mentioned this issue Feb 15, 2022
Merged
@MattIPv4 MattIPv4 changed the title Remove uglify-es, update uglify-js Remove uglify-es/uglify-js, use terser Oct 22, 2022
@MattIPv4 MattIPv4 mentioned this issue Oct 22, 2022
Open
@rbubley
Copy link

rbubley commented Nov 23, 2022

There are other examples of bad compression with uglify-js resulting in broken libraries: see, e.g. firebase/firebase-js-sdk#5962 (comment)

@MattIPv4 MattIPv4 mentioned this issue Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Needs Cloudflare Attention
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rbubley @MattIPv4