Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In NPF posts, srcset attribute prevents images from being displayed when browsing the backup in offline mode #14

Open
noughtlux opened this issue Dec 24, 2023 · 1 comment

Comments

@noughtlux
Copy link

In both old format posts and NPF posts, images are downloaded properly during the backup process. Nevertheless, by opening the downloaded backup in browser in offline mode, images are displayed correctly in posts in the old format only, while in NPF posts images are not displayed. Inspecting the source page of both types of posts in the backup, I noticed that in NPF posts there was the srcset attribute, while in the old format ones there was not. Deletion of this attribute in the source code of a single NPF post resulted in the image of the post itself being displayed correctly

OS: Debian 12.4
Browser: Firefox 115.6.0esr
This repo cloned at: 563d6f1 commit

@jessienab
Copy link

jessienab commented May 3, 2024

Still happening. Can confirm the images ARE downloaded locally, and accessing the file directly in the browser (ex. ../media/filename.jpg) will load it directly and properly; it just does not work in the offline posts.

OS: Arch Linux
Browser: IceCat (Firefox) 115.9.1esr
pip install tumblr-utils[all] on 2024-05-03 , 1.0.2.post1

I can provide sample files if needed. I'm not sure if I'm using NPF posts though... sample of the issue rendered in browser:

Screenshot from 2024-05-03 18-43-53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants