Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cedar-java-hello-world build for versions >2.3 #168

Open
2 tasks
khieta opened this issue Jun 29, 2024 · 3 comments
Open
2 tasks

Fix cedar-java-hello-world build for versions >2.3 #168

khieta opened this issue Jun 29, 2024 · 3 comments
Labels
internal-improvement Refactoring, performance improvement, or other non-breaking change

Comments

@khieta
Copy link
Contributor

khieta commented Jun 29, 2024

Category

cedar-java-hello-world

Describe the expansion you'd like to request

Currently the documentation says that the Java example only works with cedar-java version 2.3.x, and the CI only tests this version (for all branches).

  1. The most recently release version of cedar-java on Maven (at time of writing) is 3.1.2, so the build instructions should be updated to account for this
  2. The CI in this repository should be updated to support testing a specified version of cedar-java, like we do for our other examples (e.g., see build_tiny_todo_reusable.yml)
  3. The CI in cedar-policy/cedar-java should be updated to build cedar-java-hello-world as a downstream dependency

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@khieta khieta added internal-improvement Refactoring, performance improvement, or other non-breaking change backlog labels Jun 29, 2024
@mark-creamer-amazon
Copy link
Contributor

mark-creamer-amazon commented Jul 15, 2024

  1. The most recently release version of cedar-java on Maven (at time of writing) is 3.1.2, so the build instructions should be updated to account for this

#170 is merged, and item 1 is complete.

I believe we should backport the changes for 3.1.x as well.

  1. The CI in this repository should be updated to support testing a specified version of cedar-java, like we do for our other examples (e.g., see build_tiny_todo_reusable.yml)

I'll work on this next.

@mark-creamer-amazon
Copy link
Contributor

  1. The CI in this repository should be updated to support testing a specified version of cedar-java, like we do for our other examples (e.g., see build_tiny_todo_reusable.yml)

#173 is merged, and item 2 is complete.

@mark-creamer-amazon
Copy link
Contributor

mark-creamer-amazon commented Jul 17, 2024

Backported for release/3.1.x: #174.

Going to make the changes for main next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-improvement Refactoring, performance improvement, or other non-breaking change
Projects
None yet
Development

No branches or pull requests

4 participants