Fix corpus tests #16
Closed
Fix corpus tests #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm holding off merging this until our error alerts for broken tests are working! Thanks! |
This was referenced Jul 3, 2024
|
I've added your changes to #22. The integration tests are now running successfully! Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Hi 👋 I've been working on standardizing Cedar's JSON interfaces (including the integration tests), and made a couple edits recently that will affect
cedar-go. I believe the changes I've made here will fix any breaks.Tested with:
go test -count=1 -v -tags corpus ./integration_tests/...Related PRs:
cedar: FFI nits cedar#837cedar-integration-tests: Regenerate corpus to match cedar#837 cedar-integration-tests#4