Fix up nightly corpus tests #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the `-o pipefail` behavior that you might expect to be a default (see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference). Without this setting, `go test -count=1 -v -tags corpus ./integration_tests/... | tail` will always return a success error code. Signed-off-by: Patrick Jakubowski <[email protected]>
…d run. Right now, the only other way to run the tests is to invoke them manually. If I'm running them against some experiment in my branch, I don't want to alert anybody about the failure. Signed-off-by: Patrick Jakubowski <[email protected]>
…led in some fatal way. Commit [b6e8040](cedar-policy/cedar-integration-tests@b6e8040) reduced the size of the tgz file by 25%, which was the likely culprit in reducing the size of the test suite. Signed-off-by: Patrick Jakubowski <[email protected]>
Signed-off-by: Patrick Jakubowski <[email protected]>
…edar-policy/cedar-go/pull/16/files). Signed-off-by: Patrick Jakubowski <[email protected]>
patjakdev
commented
Jul 3, 2024
Comment on lines
+10
to
+12
| defaults: | ||
| run: | ||
| shell: bash |
There was a problem hiding this comment.
Setting bash here invokes the default -o pipefail behavior that correctly makes it so that the go test -count=1 -v -tags corpus ./integration_tests/... | tail fails when the tests fail.
patjakdev
commented
Jul 3, 2024
| @@ -26,7 +30,7 @@ jobs: | |||
| run: go test -count=1 -v -tags corpus ./integration_tests/... | tail | |||
|
|
|||
| - name: Notify on Failure | |||
| if: failure() | |||
| if: failure() && github.event_name == 'schedule' | |||
There was a problem hiding this comment.
We only want to be notified when this fails in the nightly run. Manual invocations shouldn't file an issue.
philhassey
approved these changes
Jul 3, 2024
You can see a successful run of the tests over in the StrongDM fork. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: None
Description of changes:
This PR causes the Github action to fail correctly when the corpus tests have failed such that our alerting will actually be invoked.
I've also pulled in the fixes from #16 so that the tests now pass.
I'd like to make additional changes to get these to run on every PR and to check in a copy of the tests to this repo and change the alerting to let us know when the tests are out of sync with the upstream version, but I'll save those for later. This at least gets us back to status quo.