Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanoid construction is not determinisitc #259

Open
john-h-kastner-aws opened this issue Mar 19, 2024 · 0 comments
Open

Nanoid construction is not determinisitc #259

john-h-kastner-aws opened this issue Mar 19, 2024 · 0 comments
Labels
internal-improvement Refactoring, performance improvement, or other non-breaking change

Comments

@john-h-kastner-aws
Copy link
Contributor

john-h-kastner-aws commented Mar 19, 2024

Selecting EntityUIDGenMode::Nanoid option makes our generators nondeterministic because the nanoid!() macro randomly constructs an id without using a seed taken from the unstructured byte array. This isn't a major issue since it's currently only used by the cedar-policy-generators CLI, but it's a foot-gun for anyone who wants to depend on the generators as a library.

@john-h-kastner-aws john-h-kastner-aws added bug Something isn't working pending-triage Hasn't been triaged yet internal-improvement Refactoring, performance improvement, or other non-breaking change backlog and removed pending-triage Hasn't been triaged yet bug Something isn't working labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-improvement Refactoring, performance improvement, or other non-breaking change
Projects
None yet
Development

No branches or pull requests

1 participant