Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor generator code #507

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Refactor generator code #507

merged 2 commits into from
Jan 2, 2025

Conversation

shaobo-he-aws
Copy link
Contributor

@shaobo-he-aws shaobo-he-aws commented Dec 31, 2024 •
edited
Loading

Issue #, if available:

Description of changes:

  1. Removed dependency on nanoid (fix Nanoid construction is not determinisitc #259)
  2. Removed CLI and deprecated a problematic function (fix TypeNotDefined error on a minimal schema w/ built-in types #496)

@shaobo-he-aws
Refactor generator code
35d9dc9 
Signed-off-by: Shaobo He <[email protected]>
@shaobo-he-aws shaobo-he-aws requested review from cdisselkoen and john-h-kastner-aws and removed request for cdisselkoen December 31, 2024 19:44
@shaobo-he-aws
fix
9c25b5e 
Signed-off-by: Shaobo He <[email protected]>
john-h-kastner-aws
john-h-kastner-aws approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@john-h-kastner-aws john-h-kastner-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming someone who knows why we originally needed it can confirm that we can drop the CLI

@shaobo-he-aws shaobo-he-aws merged commit 7b0ef84 into main Jan 2, 2025
6 checks passed
@shaobo-he-aws shaobo-he-aws deleted the fix/shaobo/remove-generator-cli branch January 2, 2025 18:34
@shaobo-he-aws
Copy link
Contributor Author

Looks good, assuming someone who knows why we originally needed it can confirm that we can drop the CLI

IIRC, I added the CLI, presumably for OOSPLA paper evaluation.

@cdisselkoen cdisselkoen mentioned this pull request Jan 2, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-h-kastner-aws john-h-kastner-aws john-h-kastner-aws approved these changes

@cdisselkoen cdisselkoen cdisselkoen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeNotDefined error on a minimal schema w/ built-in types Nanoid construction is not determinisitc
3 participants
@shaobo-he-aws @cdisselkoen @john-h-kastner-aws