Formalize the use of bounded integers and error-on-overflow semantics #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 7, 2023 09:34
|
This PR should either include or create a new issue to change the DRT to not ignore mismatches on integer overflow errors |
andrewmwells-amazon
approved these changes
Nov 7, 2023
Not needed, since the Lean formalization isn't plugged into DRT yet. We should make sure this is done in #30 though. |
|
|
||
| ----- Definitions ----- | ||
|
|
||
| def mk (i : Int) (h : INT64_MIN ≤ i ∧ i ≤ INT64_MAX) : Int64 := |
There was a problem hiding this comment.
Nit: is it possible to put INT64_MIN ≤ i ∧ i ≤ INT64_MAX in a predicate (function)?
shaobo-he-aws
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the formalization of the Cedar semantics to reflect the fact that we're using signed 64-bit integers, along with error-on-overflow semantics for arithmetic operators.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.