review feedback

Signed-off-by: Shaobo He <[email protected]>

Author: shaobo-he-aws

cedar-policy-core/src/parser/cst_to_ast.rs

@@ -1048,7 +1048,6 @@ impl Node<Option<cst::Add>> {
         } = initial.try_as_inner()?
         {
             let cst::Member { item, access } = item_node.try_as_inner()?;
-            //let item = item.to_expr_or_special()?;
             // Among successful conversion from `Primary` to `ExprOrSpecial`,
             // an `Ident` or `Str` becomes `ExprOrSpecial::StrLit`,
             // `ExprOrSpecial::Var`, and `ExprOrSpecial::Name`. Other

cedar-policy-formatter/tests/extended_has.cedar

@@ -14,4 +14,17 @@ permit(
   zip &&
   // we are safe to access all attributes
   principal.contactInfo.address.zip == "90210"
+};
+
+// Same example without comments
+permit(
+  principal is User,
+  action == Action::"preview",
+  resource == Movie::"Blockbuster"
+) when {
+  principal has 
+  contactInfooooooooooooooooooooooooooooooooooooooooooooooo.
+  addressssssssssssssssssssss.
+  zipppppppppppp &&
+  principal.contactInfo.address.zip == "90210"
 };

cedar-policy-formatter/tests/snapshots/cedar_policy_formatter__pprint__fmt__tests__format_files@extended_has.cedar.snap

@@ -26,3 +26,18 @@ when
     .address
     .zip == "90210"
 };
+
+// Same example without comments
+permit (
+  principal is User,
+  action == Action::"preview",
+  resource == Movie::"Blockbuster"
+)
+when
+{
+  principal
+  has
+  contactInfooooooooooooooooooooooooooooooooooooooooooooooo.addressssssssssssssssssssss
+      .zipppppppppppp &&
+  principal.contactInfo.address.zip == "90210"
+};